Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Aug 2023 10:54:11 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Zhenlei Huang <zlei@freebsd.org>
Cc:        freebsd-net <freebsd-net@freebsd.org>
Subject:   Re: About IFNET_PCP_NONE
Message-ID:  <ZOxSozLKmA0eeQx5@kib.kiev.ua>
In-Reply-To: <DC95210D-FFB4-461C-BCD0-50E47DF263EF@FreeBSD.org>
References:  <DC95210D-FFB4-461C-BCD0-50E47DF263EF@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 28, 2023 at 09:51:38AM +0800, Zhenlei Huang wrote:
> Hi Konstantin,
> 
> 
> I was just about going to open a PR for https://reviews.freebsd.org/D39536 and
> realized I might made wrong assumption.
> 
> I thought IFNET_PCP_NONE is something like IEEE8021Q_PCP_BE but I second why not
> use IEEE8021Q_PCP_BE but a new const IFNET_PCP_NONE.
> 
> So despite its naming IFNET_PCP_NONE, is it actually a flag to let specific interface
> completely bypass (disable) PCP processing?
> 
> The const IFNET_PCP_NONE is defined in sys/net/if.h with 
> ```
> #define IFNET_PCP_NONE 0xff   /* PCP disabled */
> ```
I fail to understand your question.

IFNET_PCP_NONE is a value that means that no 802.1q prio is inserted into
the packet.  Otherwise, non-vlan traffic is tagged with the priority.

IEEE8021Q_PCP_BE is a name of one of the priorities, it seems from my
code reading.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZOxSozLKmA0eeQx5>