From owner-freebsd-current Thu Aug 20 02:53:15 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA25862 for freebsd-current-outgoing; Thu, 20 Aug 1998 02:53:15 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA25857 for ; Thu, 20 Aug 1998 02:53:12 -0700 (PDT) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id TAA21251; Thu, 20 Aug 1998 19:52:33 +1000 Date: Thu, 20 Aug 1998 19:52:33 +1000 From: Bruce Evans Message-Id: <199808200952.TAA21251@godzilla.zeta.org.au> To: freebsd-current@FreeBSD.ORG, roberto@eurocontrol.fr Subject: Re: Problem with Poul-Henning's commit in /etc/rc Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >Unless I'm mistaken, the latest change from Poul-Henning to /etc/rc is bad >because failures are not detected anymore. The $? check is now after the >"echo" and will check its return code, not the one from mount. Another point on the hat: the echoes are attached to the wrong mount command. There is no error checking for the nfs mount, so the echoes wouldn't harm the status if they were correctly placed. Bruce >Index: rc >=================================================================== >RCS file: /home/ncvs/src/etc/rc,v >retrieving revision 1.148 >retrieving revision 1.149 >diff -u -2 -u -r1.148 -r1.149 >--- rc 1998/08/10 19:53:50 1.148 >+++ rc 1998/08/14 06:49:05 1.149 >@@ -77,5 +77,7 @@ > umount -a >/dev/null 2>&1 > >+echo -n "Mounting NFS file systems" > mount -a -t nonfs >+echo . > if [ $? != 0 ]; then > echo "Filesystem mount failed, startup aborted" > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message