From owner-svn-ports-head@FreeBSD.ORG  Fri Sep 12 00:24:50 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D242E878;
 Fri, 12 Sep 2014 00:24:50 +0000 (UTC)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A4872B36;
 Fri, 12 Sep 2014 00:24:50 +0000 (UTC)
Received: from [192.168.0.132] (vie-188-118-244-060.dsl.sil.at
 [188.118.244.60])
 by ainaz.pair.com (Postfix) with ESMTPSA id 2154D3F5DB;
 Thu, 11 Sep 2014 20:24:44 -0400 (EDT)
Date: Fri, 12 Sep 2014 02:24:42 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Tijl Coosemans <tijl@FreeBSD.org>
Subject: Re: svn commit: r367888 - in head: accessibility/accerciser
 accessibility/jovie accessibility/kaccessible accessibility/kdeaccessibility4
 accessibility/kmag accessibility/kmousetool accessibility/kmout...
In-Reply-To: <20140911171600.6c6527c5@kalimero.tijl.coosemans.org>
Message-ID: <alpine.LSU.2.11.1409120201290.2669@tuna.site>
References: <201409102050.s8AKobw3056642@svn.freebsd.org>
 <20140911000146.GO43982@hades.panopticon>
 <20140911001739.GP43982@hades.panopticon>
 <alpine.LSU.2.11.1409110220490.2867@tuna.site>
 <20140911171600.6c6527c5@kalimero.tijl.coosemans.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Sep 2014 00:24:50 -0000

On Thu, 11 Sep 2014, Tijl Coosemans wrote:
> devel/kBuild wasn't bumped either (reported on emulation@).

I looked into this, and so far have not been able to see why
Tools/scripts/bump_revision.pl did not catch this one.


In some other cases, ports were a bit more creative than I'd
usually recommend, using a pattern like the following:

    PORTREVISION?= ${XORG_REVISION}
    :
    .if defined(WITH_NEW_XORG)
     XORG_REVISION= 8
     :
     .else
     XORG_REVISION= 13
     :
     .endif

Good luck handling things like that with a simple script.

If it were me, I'd just make this port XORG_REVISION=13 for
both branches, and thus simplify this.  I am not sure the
complexity here is worth it.

Gerald