Date: Fri, 12 Sep 2014 02:24:42 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org Subject: Re: svn commit: r367888 - in head: accessibility/accerciser accessibility/jovie accessibility/kaccessible accessibility/kdeaccessibility4 accessibility/kmag accessibility/kmousetool accessibility/kmout... Message-ID: <alpine.LSU.2.11.1409120201290.2669@tuna.site> In-Reply-To: <20140911171600.6c6527c5@kalimero.tijl.coosemans.org> References: <201409102050.s8AKobw3056642@svn.freebsd.org> <20140911000146.GO43982@hades.panopticon> <20140911001739.GP43982@hades.panopticon> <alpine.LSU.2.11.1409110220490.2867@tuna.site> <20140911171600.6c6527c5@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 11 Sep 2014, Tijl Coosemans wrote:
> devel/kBuild wasn't bumped either (reported on emulation@).
I looked into this, and so far have not been able to see why
Tools/scripts/bump_revision.pl did not catch this one.
In some other cases, ports were a bit more creative than I'd
usually recommend, using a pattern like the following:
PORTREVISION?= ${XORG_REVISION}
:
.if defined(WITH_NEW_XORG)
XORG_REVISION= 8
:
.else
XORG_REVISION= 13
:
.endif
Good luck handling things like that with a simple script.
If it were me, I'd just make this port XORG_REVISION=13 for
both branches, and thus simplify this. I am not sure the
complexity here is worth it.
Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.11.1409120201290.2669>