From owner-freebsd-emulation@FreeBSD.ORG Tue Nov 25 22:26:32 2008 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD5CC1065674 for ; Tue, 25 Nov 2008 22:26:32 +0000 (UTC) (envelope-from tijl@ulyssis.org) Received: from mailrelay003.isp.belgacom.be (mailrelay003.isp.belgacom.be [195.238.6.53]) by mx1.freebsd.org (Postfix) with ESMTP id 5EA738FC20 for ; Tue, 25 Nov 2008 22:26:32 +0000 (UTC) (envelope-from tijl@ulyssis.org) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AiQFAAwKLElR9SgM/2dsb2JhbACBbdElgn0 Received: from 12.40-245-81.adsl-dyn.isp.belgacom.be (HELO kalimero.kotnet.org) ([81.245.40.12]) by relay.skynet.be with ESMTP; 25 Nov 2008 23:26:30 +0100 Received: from kalimero.kotnet.org (kalimero.kotnet.org [127.0.0.1]) by kalimero.kotnet.org (8.14.3/8.14.3) with ESMTP id mAPMQPKE008730; Tue, 25 Nov 2008 23:26:26 +0100 (CET) (envelope-from tijl@ulyssis.org) From: Tijl Coosemans To: freebsd-emulation@freebsd.org, Alex Kozlov Date: Tue, 25 Nov 2008 23:26:23 +0100 User-Agent: KMail/1.9.10 References: <20081124220311.GA14308@ravenloft.kiev.ua> <1227608432.1731.72.camel@localhost> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200811252326.25299.tijl@ulyssis.org> Cc: Jan Henrik Sylvester , Gerald Pfeifer Subject: Re: wine-1.1.8 regression -- wine: could not load L"...": Invalid address X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2008 22:26:32 -0000 Alex, On Tuesday 25 November 2008 22:39:25 Gerald Pfeifer wrote: > Alex, would you mind submitting this patch upstream as well, to=20 > wine-patches@winehq.org Cc:ing me on that? (If you prefer, I can > also do this, but since it's your patch...) >=20 > I'm currently travelling and will try to update our port in the > next couple of days; the earlier this gets upstream or at least > upstream review the better. It should probably first be discussed with Alexandre Julliard. The original code fails because it ends up allocating the virtual heap somewhere in the beginning of address space which probably interferes with other mappings. The patch moves this to (address_space_limit - 10 * VIRTUAL_HEAP_SIZE). I'm not sure that's correct. I think simply 0x80000000 would be better, but that's what Alexandre can tell you. Also, in the #else case you change a 1 into a 0. Is that intentional? =2D =A0 =A0if (!wine_mmap_enum_reserved_areas( alloc_virtual_heap, &heap_ba= se, 1 )) + =A0 =A0if (!wine_mmap_enum_reserved_areas( alloc_virtual_heap, &heap_base= , 0 ))