From owner-freebsd-hackers@freebsd.org Thu Apr 16 18:13:39 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D2EBD2C3DCB for ; Thu, 16 Apr 2020 18:13:39 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4936mL62M7z3NT9 for ; Thu, 16 Apr 2020 18:13:38 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 03GIDbvK047016; Thu, 16 Apr 2020 11:13:37 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 03GIDa7K047015; Thu, 16 Apr 2020 11:13:36 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <202004161813.03GIDa7K047015@gndrsh.dnsmgr.net> Subject: Re: fsck parallel check In-Reply-To: <2126559d-38d8-8a95-d0d1-53a4f79fde65@grosbein.net> To: Eugene Grosbein Date: Thu, 16 Apr 2020 11:13:36 -0700 (PDT) CC: Poul-Henning Kamp , freebsd-hackers@freebsd.org, Wojciech Puchar X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4936mL62M7z3NT9 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [0.63 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.47)[-0.470,0]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.17)[0.170,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.03)[ip: (0.13), ipnet: 69.59.192.0/19(0.06), asn: 13868(0.03), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 18:13:39 -0000 > 16.04.2020 23:59, Poul-Henning Kamp wrote: > > > -------- > > In message <571d8b81-f4f9-d371-6cf2-2e7aeb82a09b@grosbein.net>, Eugene Grosbein writes: > > > >> Not necessary. Fsck tries to parse device name this way: /path/to/nameNUMBERrest > >> so it skips all chars upto last /, then extracts "name" part not containing any digits, > >> then extracts NUMBER part containing only digits, upto maximum lenght. > >> Then is uses nameNUMBER for "disk name". > > > > Yeah, that part sucks... > > > > I think it would make sense to make the heuristic that if there are any > > entries with pass > 2, then ignore the "disk name" and simply run all > > entries for each pass number in parallel, trusting root to have it > > figured out. > > > > If the highest passnumber is 2, retain the "disk name" heuristic. > > I like it. Consider my semi-silence a "no objection here". -- Rod Grimes rgrimes@freebsd.org