Date: Sun, 19 Jul 2015 18:05:30 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r392507 - head/Mk/Uses Message-ID: <wpxw-m8tx-wny@FreeBSD.org> In-Reply-To: <201507191436.t6JEa09F002291@repo.freebsd.org> (Baptiste Daroussin's message of "Sun, 19 Jul 2015 14:36:00 %2B0000 (UTC)") References: <201507191436.t6JEa09F002291@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Baptiste Daroussin <bapt@FreeBSD.org> writes:
> localbase: mostly a non user one which enforce the compiler related flags to
> lookup in localbase first to find libraries, designed to be used in
> other USES
[...]
> +.if !defined(_INCLUDE_USES_LOCALBASE_MK)
> +_INCLUDE_USES_LOCALBASE_MK= yes
> +
> +CPPFLAGS+= -I${LOCALBASE}/include
Better use -isystem to avoid accidentally picking up system headers over
bundled ones like often happens when a port bundles ffmpeg.
> +CFLAGS+= -I${LOCALBASE}/include
> +CXXFLAGS+= -I${LOCALBASE}include
^^
Typo: missing / (path separator).
> +LDFLAGS+= -L${LOCALBASE}/lib
> +.endif
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJVq8rLXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bKXcH/1wTX3YKvKJuSTs9E0QwCShJ
XmqCLtKSubdVbomtZJX25xQnxCMCYHgLLmB6S58tPg4iySpHT2C92qNDaGeRkKHj
MRxOE8N0rTsNrfNoEq8L+17Gjw7q59ihiPyETGxW9s3hV9ap5nzeFYlFg5wR8keO
fhM1sBhSlOdl57CKrFq/kr1Njtvh/UyC59Wz3K8MXaWnHCfneVS595A8ZwpBZWrP
+GePjSA8tnNTyq/vmld0StoTWTAteFcBEAIfTYIdEbjcf3B8IhZc4F2QaNCyfXTo
0QkDPDiJtLd7yhmQWP5Y37E8WoFl1tLYfIxXRVejmLSMEm2Ej0DKOOJzvMmvruM=
=NJtR
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?wpxw-m8tx-wny>