From owner-freebsd-hackers Wed Mar 10 11:21:36 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from mercury.inktomi.com (mercury.inktomi.com [209.1.32.126]) by hub.freebsd.org (Postfix) with ESMTP id ADBA31547C for ; Wed, 10 Mar 1999 11:21:33 -0800 (PST) (envelope-from jplevyak@inktomi.com) Received: from proxydev.inktomi.com (proxydev.inktomi.com [209.1.32.44]) by mercury.inktomi.com (8.9.1a/8.9.1) with ESMTP id LAA08202; Wed, 10 Mar 1999 11:21:24 -0800 (PST) Received: (from jplevyak@localhost) by proxydev.inktomi.com (8.8.5/8.7.3) id LAA16727; Wed, 10 Mar 1999 11:21:15 -0800 (PST) Message-ID: <19990310112115.B16206@proxydev.inktomi.com> Date: Wed, 10 Mar 1999 11:21:15 -0800 From: John Plevyak To: "Richard Seaman, Jr." , John Plevyak Cc: hackers@freebsd.org Subject: Re: bug in linuxthreads for FreeBSD References: <19990309172626.A7182@proxydev.inktomi.com> <19990310105944.F4440@tar.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.93.2i In-Reply-To: <19990310105944.F4440@tar.com>; from Richard Seaman, Jr. on Wed, Mar 10, 1999 at 10:59:44AM -0600 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Mar 10, 1999 at 10:59:44AM -0600, Richard Seaman, Jr. wrote: > On Tue, Mar 09, 1999 at 05:26:26PM -0800, John Plevyak wrote: > > > I have been using the linuxthreads for FreeBSD port, and running > > it under high stress. > > Glad to see it. Also glad you can only find *one* bug :) Actually, the p_nextwaiting list has a tendency to circularize as well, but I am still working on that :) > > > Also, there is no 'lock prefix' before the xchg in _atomic_lock.S which > > will prevent the library from working correctly with SMP. > > I'd like to know more about this. According to the Intel documents > I have, the xchg op code implies a 'lock prefix'. You can add the > 'lock prefix', but its redundant. Your right, that's what I get for assuming any consistency in the x86 ISA. > > -- > Richard Seaman, Jr. email: dick@tar.com > 5182 N. Maple Lane phone: 414-367-5450 > Chenequa WI 53058 fax: 414-367-5852 > *** condvar.c.orig Wed Mar 10 10:12:49 1999 > --- condvar.c Wed Mar 10 10:13:37 1999 > *************** > *** 152,157 **** > --- 152,158 ---- > > #endif > /* Otherwise, return normally */ > + remove_from_queue(&cond->c_waiting, self); > release(&cond->c_spinlock); > pthread_mutex_lock(mutex); > return 0; Testing now. I'll keep you informed. -- John Bradley Plevyak, PhD, jplevyak@inktomi.com, PGP KeyID: 051130BD Inktomi Corporation, 1900 S. Norfolk Street, Suite 110, San Mateo, CA 94403 W:(415)653-2830 F:(415)653-2801 P:(888)491-1332/5103192436.4911332@pagenet.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message