Date: Fri, 18 May 2018 16:32:49 -0400 From: "John W. O'Brien" <john@saltant.com> To: Kurt Jaeger <lists@opsec.eu>, Eitan Adler <lists@eitanadler.com> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: Practice of "Sponsored by" in commit messages Message-ID: <01f89a53-c53a-45fa-1bd4-9a4c07909ebe@saltant.com> In-Reply-To: <20180518182005.GG37752@home.opsec.eu> References: <CAH7qZfs8eNMkkeQ0eyV5AcapOCQFFL1fUiBDR1aM1875-Cy-Lg@mail.gmail.com> <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> <CAH7qZfu6j%2Bc-HpjHnwxyeQTKwX9DavN4iAzSpMO5Kjy9VJ2uHw@mail.gmail.com> <732c3f40-1765-6883-dbec-f5c77db8e30c@saltant.com> <CAH7qZftNadmygyPNW9HNPWTY9kU6W7j-409CrV0XGk6ZYDQTug@mail.gmail.com> <7b14a5c4-7320-8f5e-b8c3-f49809caf9e5@saltant.com> <20180518041501.GF37752@home.opsec.eu> <CAF6rxgnHeSEAOw_qbMeWEiSEX3dbcu7ASPBVthsCXkaZ%2Bf%2BBaQ@mail.gmail.com> <31190803-e6ba-428b-0954-341dad2f1916@saltant.com> <CAF6rxgmNL2pRJwJUz39Cfw=Di5sfhN3PvSCfwTrsupQ86gHcFw@mail.gmail.com> <20180518182005.GG37752@home.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ONRxiO96xwUPxLysWXljDLRhAtK1WtSzI Content-Type: multipart/mixed; boundary="i6APNLE9JMBQmdxNWlj0vQGVRFLsNTLeq"; protected-headers="v1" From: "John W. O'Brien" <john@saltant.com> To: Kurt Jaeger <lists@opsec.eu>, Eitan Adler <lists@eitanadler.com> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Message-ID: <01f89a53-c53a-45fa-1bd4-9a4c07909ebe@saltant.com> Subject: Re: Practice of "Sponsored by" in commit messages References: <CAH7qZfs8eNMkkeQ0eyV5AcapOCQFFL1fUiBDR1aM1875-Cy-Lg@mail.gmail.com> <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> <CAH7qZfu6j+c-HpjHnwxyeQTKwX9DavN4iAzSpMO5Kjy9VJ2uHw@mail.gmail.com> <732c3f40-1765-6883-dbec-f5c77db8e30c@saltant.com> <CAH7qZftNadmygyPNW9HNPWTY9kU6W7j-409CrV0XGk6ZYDQTug@mail.gmail.com> <7b14a5c4-7320-8f5e-b8c3-f49809caf9e5@saltant.com> <20180518041501.GF37752@home.opsec.eu> <CAF6rxgnHeSEAOw_qbMeWEiSEX3dbcu7ASPBVthsCXkaZ+f+BaQ@mail.gmail.com> <31190803-e6ba-428b-0954-341dad2f1916@saltant.com> <CAF6rxgmNL2pRJwJUz39Cfw=Di5sfhN3PvSCfwTrsupQ86gHcFw@mail.gmail.com> <20180518182005.GG37752@home.opsec.eu> In-Reply-To: <20180518182005.GG37752@home.opsec.eu> --i6APNLE9JMBQmdxNWlj0vQGVRFLsNTLeq Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/18/18 14:20, Kurt Jaeger wrote: > Hi! >=20 >>>>>> The FreeBSD project could help by asking committers to qualify >>>>>> "Sponsored by" lines to indicate which participant(s) is(are) spon= sored, >>>>>> in way that is equivalent to the way that the actual work itself i= s >>>>>> customarily attributed. >=20 >>>>> This sounds reasonable, so I suggest that you submit a >>>>> patch to the ports handbook that describes it for maintainers >>>>> and committers. >=20 >>>> One thing to note: FreeBSD has a custom patch to subversion to detec= t >>>> "ORGANIZATION_NAME" and automatically append it to the default >>>> template. This is likely why its getting added in unexpected places.= >=20 >>> How do you think I should handle that in my forthcoming doc patch? Is= >>> there a related bug I should file against services? >=20 >> Its a client side patch of the subversion binary. I'm not sure the >> best way to handle it beyond perhaps changing the template a bit? >=20 > What change would be needed ? There's already a Sponsored by field ? >=20 > The custom patch is here: >=20 > https://svnweb.freebsd.org/ports/head/devel/subversion/files/extra-patc= h-fbsd-template?revision=3D411397&view=3Dmarkup I agree that this won't necessarily need to change. If anything, a very small reminder to committers, or suggestive wording change, to fix-up the the sponsorship line when applicable. I will submit a separate bug with a candidate change that depends on the doc bug. I won't mind if the doc bug is accepted and the subversion portbug is closed WONTFIX upon review. --=20 John W. O'Brien OpenPGP keys: 0x33C4D64B895DBF3B --i6APNLE9JMBQmdxNWlj0vQGVRFLsNTLeq-- --ONRxiO96xwUPxLysWXljDLRhAtK1WtSzI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKpEHkkRoSDiIJkQOWPtK56pP/m4FAlr/OHIACgkQWPtK56pP /m66dAgAqCNu8iq7kDix5hULrY6tgdKEVLINKUXvUu9n2EGiK4qXWe2xczHYQhHs sWH6VOCyleWgLPC8+hZD878rQ1goa9G93Pa7fn8tnZWogHQR/wBelrLhbMsXvzqd oaurrcnnD/tO9YKQgQhIpfuv03vhlnC+CiqSg7piB0/f83ZmgtIQtm4CncrWDhoS JFnTLntkDaW9ycbuS1kOnn8A/bMIOSVL60QxIqFoPyCn9OrscLfzw8/gWrcJJjCk qVNh6qiqUdbX1PVwLEiPqD1eIiRC0igNiR2Cmmy+j8NTZYJiOWJn++3o9wI/nEN9 NrMVGp9TmxIfv/fC33CL/lbhdk4bgA== =QO6w -----END PGP SIGNATURE----- --ONRxiO96xwUPxLysWXljDLRhAtK1WtSzI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01f89a53-c53a-45fa-1bd4-9a4c07909ebe>