From owner-freebsd-current@FreeBSD.ORG  Tue Oct  4 09:49:38 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 74BB916A41F
	for <current@freebsd.org>; Tue,  4 Oct 2005 09:49:38 +0000 (GMT)
	(envelope-from fli+freebsd-current@shapeshifter.se)
Received: from mx1.h3q.net (manticore.shapeshifter.se [212.37.5.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F348143D45
	for <current@freebsd.org>; Tue,  4 Oct 2005 09:49:37 +0000 (GMT)
	(envelope-from fli+freebsd-current@shapeshifter.se)
Received: from localhost (localhost [127.0.0.1])
	by mx1.h3q.net (Postfix) with ESMTP id 2D7E11A753
	for <current@freebsd.org>; Tue,  4 Oct 2005 11:49:37 +0200 (CEST)
Received: from mx1.h3q.net ([127.0.0.1])
	by localhost (manticore.shapeshifter.se [127.0.0.1]) (amavisd-new,
	port 10024) with ESMTP id 75730-18 for <current@freebsd.org>;
	Tue,  4 Oct 2005 11:49:36 +0200 (CEST)
Received: from [10.0.3.123] (sto-nat.se.tangram-group.net [212.37.5.19])
	by mx1.h3q.net (Postfix) with ESMTP id 2F5981A750
	for <current@freebsd.org>; Tue,  4 Oct 2005 11:49:36 +0200 (CEST)
Message-ID: <43425033.6070409@shapeshifter.se>
Date: Tue, 04 Oct 2005 11:49:39 +0200
From: Fredrik Lindberg <fli+freebsd-current@shapeshifter.se>
User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050928)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: current@freebsd.org
References: <433FB9B9.9020207@shapeshifter.se>	<20051003.132634.20912224.imp@bsdimp.com>	<4341A55B.1070209@shapeshifter.se>
	<20051003.165337.14303305.imp@bsdimp.com>
In-Reply-To: <20051003.165337.14303305.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: at mail.hamnpolare.net
Cc: 
Subject: Re: Linksys EG1032 rev. 3 patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2005 09:49:38 -0000

M. Warner Losh wrote:
> In message: <4341A55B.1070209@shapeshifter.se>
>             Fredrik Lindberg <fli+freebsd-current@shapeshifter.se> writes:
> : Filtering on subvendor/subdevice might be better, I didn't even think
> : of that and revision filtering seemed to be quite popular among
> : exsisting drivers.
> 
> Yes.  Many chip vendors bump the revision field 'often'.  Just how
> often varies from chip maker to chip maker.  Some do only when they
> have a new version of the chip that needs special work arounds (or
> that no longer needs them :-).  Others do change it for each change to
> the silicon.  Most are somewhere inbetween.
> 
> : The subdevice id for a rev.3 card seems to be 0x0024 (subvendor 0x1737).
> : I don't own a rev. 2 card but google says that the rev.2 card has
> : subdevice id 0x0015 (subvendor 0x1737).
> 
> That might be sufficient...
> 
Ok, how should this be implemented then? Just a specific check in each
drivers probe methods or by adding some svid/sdid fields to
struct rl_type and similar structs.
I would go for the latter, but that might be overkill.

     Fredrik