From owner-freebsd-hackers@freebsd.org  Tue May  1 18:22:28 2018
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 000D2FB32BF
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Tue,  1 May 2018 18:22:27 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 9E6A468451;
 Tue,  1 May 2018 18:22:27 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com
 [209.85.215.49])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 55ED82BAA0;
 Tue,  1 May 2018 18:22:27 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-lf0-f49.google.com with SMTP id g12-v6so17334751lfb.10;
 Tue, 01 May 2018 11:22:27 -0700 (PDT)
X-Gm-Message-State: ALQs6tAq7evczB7rbk8I3K+BL8oCUTPp/1CCVSJn+UnhSxF5B0EZk/75
 AjCXdz223OpcMQEFrYV8FQE0400hsF+StgAUVgk=
X-Google-Smtp-Source: AB8JxZp+nHgFCShNErVpna8EwBi8NR3o36XExwd5Bs+54NdFJGa8mQg0tsT4INpfhbydPrn3Av7r8G0GNisdITJvSJ8=
X-Received: by 2002:a2e:8794:: with SMTP id
 n20-v6mr11775211lji.38.1525198945943; 
 Tue, 01 May 2018 11:22:25 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.46.129.90 with HTTP; Tue, 1 May 2018 11:22:05 -0700 (PDT)
In-Reply-To: <CANCZdfr0pRiN08ZVn+2x+Tk6suAbkg7Ui_X-9S=E14WfqDFMYg@mail.gmail.com>
References: <7630266D-D078-41B3-BC27-32EBF65540C4@gmail.com>
 <CACNAnaEEd_DoJg_9B=Y2GuL=R40ShTA27fgXis3jMiSgVdN9-A@mail.gmail.com>
 <CANCZdfr0pRiN08ZVn+2x+Tk6suAbkg7Ui_X-9S=E14WfqDFMYg@mail.gmail.com>
From: Kyle Evans <kevans@freebsd.org>
Date: Tue, 1 May 2018 13:22:05 -0500
X-Gmail-Original-Message-ID: <CACNAnaGmHK1WoXHX2rvJR=50p+1gX72M7+M-KH5YzET=e48_UQ@mail.gmail.com>
Message-ID: <CACNAnaGmHK1WoXHX2rvJR=50p+1gX72M7+M-KH5YzET=e48_UQ@mail.gmail.com>
Subject: Re: Bug 207069 (loader password kills boot)
To: Warner Losh <imp@bsdimp.com>
Cc: David Cross <dcrosstech@gmail.com>,
 FreeBSD Hackers <freebsd-hackers@freebsd.org>, 
 Devin Teske <dteske@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 May 2018 18:22:28 -0000

On Tue, May 1, 2018 at 1:17 PM, Warner Losh <imp@bsdimp.com> wrote:
>
>
> On Tue, May 1, 2018 at 12:12 PM, Kyle Evans <kevans@freebsd.org> wrote:
>>
>> On Tue, May 1, 2018 at 1:07 PM, David Cross <dcrosstech@gmail.com> wrote:
>> > The aforementioned bug has been open for over 2 years, with attached and
>> > tested patches. At least one other has commented.
>> >
>> > Could we please have it for 11.2/12.0?
>>
>> Hi,
>>
>> CC'ing Devin, our local Forth-fu-fighter. If it looks ok to Devin, one
>> of us should go ahead and shuffle this through.
>
>
> Yes. I've looked at this code a fair amount, and I don't understand why this
> is needed and why it would make things work. Since it is a security thing,
> I'm very reluctant to push it in absent better understanding of why it
> works.
>

Right, it also confuses me. =)

When I was implementing this stuff for Lua, autoboot DTRT as long as
module_path is setup correctly -- this is probably the part that's
missing since IIRC that's usually done in menu setup (that doesn't
happen here).

I'm not sure if this the right way to fix it in Forth-land, though.