From owner-freebsd-current Tue Aug 13 6:59:57 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0680637B4AA for ; Tue, 13 Aug 2002 06:59:47 -0700 (PDT) Received: from dilbert.robbins.dropbear.id.au (101.f.012.mel.iprimus.net.au [210.50.253.101]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC05C43E3B for ; Tue, 13 Aug 2002 06:59:44 -0700 (PDT) (envelope-from tim@robbins.dropbear.id.au) Received: from dilbert.robbins.dropbear.id.au (9cv8scxdvfz0pz27@localhost [127.0.0.1]) by dilbert.robbins.dropbear.id.au (8.12.3/8.12.3) with ESMTP id g7DDxfKF010678; Tue, 13 Aug 2002 23:59:42 +1000 (EST) (envelope-from tim@dilbert.robbins.dropbear.id.au) Received: (from tim@localhost) by dilbert.robbins.dropbear.id.au (8.12.3/8.12.3/Submit) id g7DDxdYg010677; Tue, 13 Aug 2002 23:59:40 +1000 (EST) Date: Tue, 13 Aug 2002 23:59:39 +1000 From: Tim Robbins To: David Xu Cc: current@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_sig.c (fwd) Message-ID: <20020813235939.A10212@dilbert.robbins.dropbear.id.au> References: <3D584E87.4EAB0D0E@mindspring.com> <20020813131438.77207.qmail@web20906.mail.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020813131438.77207.qmail@web20906.mail.yahoo.com>; from bsddiy@yahoo.com on Tue, Aug 13, 2002 at 06:14:38AM -0700 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Aug 13, 2002 at 06:14:38AM -0700, David Xu wrote: > --- Terry Lambert wrote: > > I did. It's still an order of operation problem in the kernel > > during fork(), as Bruce pointed out in a later posting (so me > > pointing it out here is probably redundant... 8-)). > > > > I still think other code is going to have the problem, too, so > > changing su alone doesn't fix things. Better to not deliver > > the tty output stopped signal. > > > > -- Terry > > Don't touch tty code, if you change, you'll break more code, > current problem is just because su forks a child process and > want to take over some job control work from shell, it is of > course not a easy job. the problem does not exist in STABLE > branch because su does not fork. What about chpass, vipw, and the other pw_edit() consumers? vipw works correctly wrt suspending with ^Z on 4.6-RELEASE, but does not on -CURRENT. As far as I can see, pw_edit()'s logic has not been changed. This is a slightly different case to that of the shell suspending _itself_, but I think it's similar enough that the solution may be the same. Tim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message