From nobody Mon Jul 7 20:16:49 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbb9t1CVnz616lf; Mon, 07 Jul 2025 20:16:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbb9s6byCz3Knm; Mon, 07 Jul 2025 20:16:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751919409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PiUFKIMUehkC0pmasbQCzElEnuE+kkWaSXDIP5wo+uY=; b=M0EnRAZ4VqlNZie673mgutJ2fr6v6kZxtAWiqOQInS4yOy8voT1w/A4eNi1zSkDXT/Wt2q nYaw04bDkalAJwNjB0LWUo7fCN9jDZn5/p5z1U7/VfN2c4hcOuQjaXrd/GQ85jNza4g7Bn 7j2zg53gKTPaIEuhiiv/uk/LF5pzX+gYFDVvPnDNEu3q0vGaRql9LnTiVv1Q7K4g1b3ZM6 NGoqcFDYwujrKAGiFbCTXUhCB+rrPhRcR16Xm48b/82a/syOGuJDlONszlwhQUbCX7wkIK s4LVlKxHZuMTnMYHffhtmCwY8obDX4CWMf9/pR4QPpVefhJY0kzZt0iaP4BxDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751919409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PiUFKIMUehkC0pmasbQCzElEnuE+kkWaSXDIP5wo+uY=; b=c1QEyUA16jOKAsTVhN1C4qqEwbjVaEIQz+Ukbx2qUT4DoiSVBNaXtWPkflPl2qqvmPJnWa S8tJyHbLIMV7zOJy4r+Oh7a6nIdgzsbqlmFOv+3px4J/DTk+LtGkcIv6OZYLBmL/r8duKi iKosvaHS4uHjcbDj9zVHlxwm3VxA/wdRBPRWrCostzsF9dobhsf6sfuLO+JYp9zwGgUcAk sr2q89PIFbgtNIwrrXQqejVfp3PcEehSRsl3aHTJutJhgiIybVjsFluwcQ5+sVv5Z4luCr BMF+/4Zx3LnJcrKD8nAYE9qJtqFhZcH59nIDngbzXJ4IKp0kvx3GztFFZX6KtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751919409; a=rsa-sha256; cv=none; b=kAa9gpteT2sNjTIKKSYiMcbgFrOqOxuY+pXUhyL//gILtPhu/qF6FMN4bRxoPk/SmSY/A/ SJlkSL5fff8ND8baLiqG2R7tHo3lVnoqyz6FR87E9H8NqqmL/tJHr6XSomutriP8xj9lGn tb+QYPvt1lQdJEbV57yLfy+dE9UCczExJGkavG9zUW7axTboOS/8z70xpWsAAH/E+avER9 qY6Mr5QE8jtAR+nZ+IjqGTKcN8lkpBs3cbAUYt8PmdkwW061qpzvrAXDHSD7Olg7U4b9Kr zOTUc+ZRkj8dS+zdEav00XlNKghQrlG7KWaHOcB9czLuSgUTQHF4P5EXoaPlQQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bbb9s69DXz155x; Mon, 07 Jul 2025 20:16:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 567KGnkE006513; Mon, 7 Jul 2025 20:16:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 567KGnfd006510; Mon, 7 Jul 2025 20:16:49 GMT (envelope-from git) Date: Mon, 7 Jul 2025 20:16:49 GMT Message-Id: <202507072016.567KGnfd006510@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 12bef37a824c - main - dtrace: fix symbol address resolution List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 12bef37a824c52582ee8f38699b8ae4fde17068d Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=12bef37a824c52582ee8f38699b8ae4fde17068d commit 12bef37a824c52582ee8f38699b8ae4fde17068d Author: Jiacong Fang AuthorDate: 2025-07-07 18:51:51 +0000 Commit: Mark Johnston CommitDate: 2025-07-07 20:16:31 +0000 dtrace: fix symbol address resolution Dtrace assumes only ELF sections of type SHT_PROGBITS or SHT_NOBITS occupy memory space. However, sections with SHF_ALLOC flag also consume memory space. Moreover, the symbol address initialization skips symbols at the very beginning of a section in ET_REL KLDs. Fix: Check section flag for calculating section offset, and disable the skipping at the beginning of a section. PR: 288000 Reviewed by: markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D51188 --- cddl/contrib/opensolaris/lib/libdtrace/common/dt_module.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_module.c b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_module.c index 2a0386c33124..f6a328bb9b39 100644 --- a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_module.c +++ b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_module.c @@ -109,8 +109,7 @@ dt_module_syminit32(dt_module_t *dmp) if (sym->st_name == 0 || sym->st_name >= ss_size) continue; /* skip null or invalid names */ - if (sym->st_value != 0 && - (ELF32_ST_BIND(sym->st_info) != STB_LOCAL || sym->st_size)) { + if (ELF32_ST_BIND(sym->st_info) != STB_LOCAL || sym->st_size) { asrsv++; /* reserve space in the address map */ #if defined(__FreeBSD__) @@ -159,8 +158,7 @@ dt_module_syminit64(dt_module_t *dmp) if (sym->st_name == 0 || sym->st_name >= ss_size) continue; /* skip null or invalid names */ - if (sym->st_value != 0 && - (ELF64_ST_BIND(sym->st_info) != STB_LOCAL || sym->st_size)) { + if (ELF64_ST_BIND(sym->st_info) != STB_LOCAL || sym->st_size) { asrsv++; /* reserve space in the address map */ #if defined(__FreeBSD__) sym->st_value += (Elf_Addr) dmp->dm_reloc_offset; @@ -245,8 +243,7 @@ dt_module_symsort32(dt_module_t *dmp) for (i = 1; i < n; i++, dsp++) { Elf32_Sym *sym = symtab + dsp->ds_symid; - if (sym->st_value != 0 && - (ELF32_ST_BIND(sym->st_info) != STB_LOCAL || sym->st_size)) + if (ELF32_ST_BIND(sym->st_info) != STB_LOCAL || sym->st_size) *sympp++ = sym; } @@ -269,8 +266,7 @@ dt_module_symsort64(dt_module_t *dmp) for (i = 1; i < n; i++, dsp++) { Elf64_Sym *sym = symtab + dsp->ds_symid; - if (sym->st_value != 0 && - (ELF64_ST_BIND(sym->st_info) != STB_LOCAL || sym->st_size)) + if (ELF64_ST_BIND(sym->st_info) != STB_LOCAL || sym->st_size) *sympp++ = sym; } @@ -1218,7 +1214,7 @@ dt_module_update(dtrace_hdl_t *dtp, struct kld_file_stat *k_stat) continue; /* skip any malformed sections */ if (sh.sh_size == 0) continue; - if (sh.sh_type == SHT_PROGBITS || sh.sh_type == SHT_NOBITS) { + if (sh.sh_flags & SHF_ALLOC) { alignmask = sh.sh_addralign - 1; mapbase += alignmask; mapbase &= ~alignmask;