From nobody Tue Oct 7 09:00:10 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cgqpp4bpYz69pyv; Tue, 07 Oct 2025 09:00:18 +0000 (UTC) (envelope-from olce@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cgqpp46qqz41VY; Tue, 07 Oct 2025 09:00:18 +0000 (UTC) (envelope-from olce@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759827618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Encxbs01/VJe48WjO3S3zYP9FKNGFvqmfbjbSG1RgRk=; b=S5PHub196MUcYqr7bBeeKv7nKRhVATl4PUOMk32V28LPZe8sYAm0IMj45JS5rfjCnyH0cW 6ohW5ZJQY+Kcz5pLstli4QM06U8l7f2un5JUbnaiIYxARlky7TTx/ojqckP6TO7GWxF9AD RRdZQ0+EdFVvGt/OCxQo3fb/dJ0f8qAZkkewmOUXVQNNorOdeDgHsztOBcy9g/BorNDp4f BLmqAsGMPV6dQ/sBRufGi9Q9I/5skB7vQzw4B9kqoLs5lde61O5yqC6a7bkf333Tq1z0t8 nkTBJsvgx4WAI6ZxyGLec43kMbTWhvPaui9bVzcYt9gC0dCEGK8zFJyRKPvS3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759827618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Encxbs01/VJe48WjO3S3zYP9FKNGFvqmfbjbSG1RgRk=; b=uB2GI6zBEFWdUrTUd36f+slb9CQytbYv/WwYBDd4+HdQR75DOvq5h8ERynSZJ+be9Skryz a8JO0MDj3pc6xYSXmkza4WCuE8uNr8Di+4IUkRjFdRXlnpIOq+7fACnQf4VXq3h/ivg0x1 cvMsA5VN2qh7Z+eEmJbRrhCgwBAYq+08nhRQltWdS/BumELBw3ktIj6tThd4q61l0LmhAf +6wHH0Xuc4zNCXvfFeeB6l/9np7I2NNkvqh0DgXyU9LyvXCczbiCkKFBxfeDEiDRmchKjP c/KcCYV3HWW0ZTCGc1NjgCn1pJG8gm0axXeEHgF+snDFmq1prCNIUB/yN231Hw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759827618; a=rsa-sha256; cv=none; b=dPtiQvNIKnV1aKjMb6I06loyYjQrjOmiworSQekVIQiBs+xd0yL0mM9csFGGVwNMjo+QvT eal8+lMzfNwESnLo4uoemfMd+bm4K8LDlH6NIfCvBLBxQuJYmWJDVdM0ARkGeAgB44sPZz vp8hJIVTr0GanZvV0TQJ0rwrXfyAfF6D8wYxq7idjdoJ9Cdcp3HIrbZKR4KPjLhPnW6fs5 G7HxMSMq7S7BYuky9Y+VXyy2r/bBS3g303l8i795QYBOnM/k7wZWuR+9h4e4oA5mpJs0s4 TigNmux6MqOV6WOTJ1dC7iNoLSoFXE86zj/O6Pn8uGzcAnkIqzUgzUKsywnHRQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from ravel.localnet (aclermont-ferrand-653-1-222-123.w90-14.abo.wanadoo.fr [90.14.66.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: olce/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cgqpn4SyYz2qp; Tue, 07 Oct 2025 09:00:17 +0000 (UTC) (envelope-from olce@freebsd.org) From: Olivier Certner To: Mateusz Guzik , Mateusz Guzik Cc: Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 84f981ba57e7 - main - nullfs: shrink null_node to 32 bytes Date: Tue, 07 Oct 2025 11:00:10 +0200 Message-ID: <2940490.iL6vRArjjl@ravel> In-Reply-To: References: <202510061823.596IN7oZ084715@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart88061026.0ko45tJjV3"; micalg="pgp-sha384"; protocol="application/pgp-signature" --nextPart88061026.0ko45tJjV3 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Olivier Certner To: Mateusz Guzik , Mateusz Guzik Date: Tue, 07 Oct 2025 11:00:10 +0200 Message-ID: <2940490.iL6vRArjjl@ravel> MIME-Version: 1.0 > > For the hash to be at all useful the chains are supposed to be short. > > > > Or to put it differently, a sensibly sized hash with a sensible > > hashing function makes it automatically fine. > > > > This was worthwhile to do because the original size of 40 bytes is a > > very poor fit for the allocator. > > > > fwiw the namecache already works this way for few years. > > > > the regular vnode hash should probably get the same treatment, saving > > 8 bytes off of struct vnode > > I can concede it would make sense to include this in the commit message. That's a reasonable trade-off, but it's important that such choices are explained in the commit message and/or code comments. Next time, please consider putting up Phabricator reviews even for such "small" changes, where we would have had the opportunity to mention this before commit. Thanks and regards. -- Olivier Certner --nextPart88061026.0ko45tJjV3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmjk1psACgkQjKEwQJce JicviBAAs01XxVdfCbvErgsCm3v8n9zlp8IJYKL7KKzI1+9eQFRmCR/C735QIcOp 9VSgl35MVL4pm074O79HNn6iNXJCXcqCRFxDKrLWH6afReGQ4CkwhOOFWNBeCrty 037s0d3GaBzOzqxRzbSfEDf9+Yvsc2vKoJGCWmtu4eZ/smz6nGK7AiHCNaW8ldRv zuy0yFhP+gw4OkAm0W6N8a1gLq7/2HT6PdZ3bxGD+ZYXI8mGZ877C44tTqLsAkPZ O89Yw8dGdBCnR2lhr/fcyRYicJa+j92t48CK+h9wdW213evzt+yU/aS/4+HkBznC Tkdw/TlK3k8x6/ECPER09v6XKOVw67z6HxMOf51G+X4Jo3lj+a1LOhcUWNZvSDJw pOmpWBI5UDqNwstUv+BKlND0wbBUCGp5lq/CQcY8XFFn0TWILBR0EeJsXTgLqgPk j1QI4591xT86IUO+L9xyMJ/o9OUhL4L9s1KMNAMBFi0rTPoV72nwJu4QY1Klnc4h jaNc6JKKKPPSPvVIcOFNRs/SDKpCcR8ln0dJ9+PsufIIMcMz9QlX3+zXgheH9ixQ JnFTgM71P1bDKlTXBe1N4nYNl7S2BltwNxwiF/gVG+jFVgTi5iSuhF5YgA8lfg2C cVN7Uz+ccJ6AWCBveqLQJThHGKQeGnp+GUrRhZBh9T4ni/wHX6s= =BPAy -----END PGP SIGNATURE----- --nextPart88061026.0ko45tJjV3--