From nobody Tue Apr 21 17:16:09 2026 X-Original-To: freebsd-testing@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g0TXn1m9nz6YZnN for ; Tue, 21 Apr 2026 17:16:25 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g0TXm60Xyz3R8t for ; Tue, 21 Apr 2026 17:16:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-35d99bae2ebso4136986a91.3 for ; Tue, 21 Apr 2026 10:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776791782; x=1777396582; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=edhl2ibI1QYHYT7B/LVC2JRS1fhiK9idDiQSUjiSxWo=; b=OwNWxBU+5fVu7WpM4cqbHqKaw842BlC3yF+bOCrSjXjVJeSC5Tx4cxw3i63LyNtBuW ZS/Gno4CpUKs9CL00uo2u0QHMXZtv2SHg6oGl0h+GthVGgKqc9Iqk6Fd4J4FAlF4mCcH D1YEQjxiGokFdzUYaKaeKCvZm4sk2pMQ9KEmOcjfY2Ev1KffDk858fikR2U6rEJIzAlL eEdSQ6e0HoGUQ+ljgARufff+Q5BrbSKQEITedkBatfvVodyYa+k5htQAkMB+Yxw8OOXj j3jYItPXKbiK4sOQVzlua1SXw13JbS17ogOWoSneyuP/4kBOENWbeTfuE+9AN1tGpzjK VAXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776791782; x=1777396582; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=edhl2ibI1QYHYT7B/LVC2JRS1fhiK9idDiQSUjiSxWo=; b=IyFn6SwtnErflW+Y3uFbmV+4uZUhZrPxvck0eI3SCQzS/m6iGzVzGbkQzEkeB1yP7i UqAU0e+MI8c1VDpmSghx+wB0/QhWb/I4eE9FnqEyPka+gBR6eYuwraBDYs+p/88EIpgh +H2vSqBykvrNnqvfMv3x4hdi0H9H28f855Zs0SeuuXfoT0v9IXIPxGG50cmwPXiacPNR htc4lZltQU3r7Fow1QgYWCWka/BzAW1C5/vGS11KJI8vvyJ6FQwppG+gC6ZDjP1piE+n zOWXXVxN6QqQykFkzNlDtBkoWk/aDJAyDZd1Z3/9nFgUehi1MomMaMqfisgdGn2Wspzy 65cw== X-Forwarded-Encrypted: i=1; AFNElJ9OQJrZtcq9u+QlqaETX7K+fkRf9sY7WN69WozrHX6i6BumqppbW/FCijM23UXrGrG/qEZ6WApDCmtRPhEFds8=@freebsd.org X-Gm-Message-State: AOJu0Ywq9ljmYXddLKIXYPHjV/RwzhtQEF/MQl+0qbPVetx0B14WE+gD iA1qoYVKdcTZFwPON+4l7ehS9O9UgasLy3fWpPzdYDsE6DqFdxyBlxtS X-Gm-Gg: AeBDievAVSE3EHyUamj1dPA0Fiwi3ldwMUCC1yv2fQRqDM3QfmA8EEUxOss7IMBAhzu gdOeRk6YYJsJD1KOpERr1IVgBbVGH5VYO1C/12eqMdndRKRS3QzY1ojUbUb47nDZd6urnBI2D3k Ir3co+B2KZqvvwg/OPhNWhihAo/LXXkw2GFmRIMTdqU3gHoG5l9aCCyiFq2WPp5LMQ9ZXD8S8hn XeRaRRaqwtdphbNJb7gL0K/6zkbPY9jY82UZbag9SregjVErWNMpx2YbY2aK1rLaUTHJe4avhVy Kg/C2xvahoaDbVZBO+ecSgq5SXS7e6JwpU20BggQHxja3/Cn79WljGvU9tz8tAtQZzjnYVMI6e2 Kt7XiiDYJx9XNIKAPcUS5/8R+iTF9cRZ8RGTvw0/9QNcodLLiLEOp0ePO5WBHKvZymvopZOyDXI FAOhaIxZsauHiMTNwiMg1BS5VzrDyujaBAebqfc/SWs/H+cbvSEQAN6vaKPFJXp+PYBcM= X-Received: by 2002:a17:90b:1804:b0:35d:9da0:4947 with SMTP id 98e67ed59e1d1-361403f15abmr19878163a91.11.1776791781855; Tue, 21 Apr 2026 10:16:21 -0700 (PDT) Received: from smtpclient.apple ([84.39.151.101]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-361410bafa9sm14256866a91.15.2026.04.21.10.16.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Apr 2026 10:16:21 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_44BAE9A2-AC80-41C6-A611-9829BF407786"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Testing List-Archive: https://lists.freebsd.org/archives/freebsd-testing List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-testing@freebsd.org Sender: owner-freebsd-testing@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: pjdfstest integration From: "Enji Cooper (yaneurabeya)" In-Reply-To: Date: Tue, 21 Apr 2026 10:16:09 -0700 Cc: Mark Johnston , freebsd-testing@freebsd.org Message-Id: <1585B8BA-5847-40B3-A655-700BD800318C@gmail.com> References: To: Alan Somers X-Mailer: Apple Mail (2.3864.400.21) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4g0TXm60Xyz3R8t X-Spamd-Bar: ---- --Apple-Mail=_44BAE9A2-AC80-41C6-A611-9829BF407786 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 21, 2026, at 9:44=E2=80=AFAM, Alan Somers = wrote: >=20 > On Tue, Apr 21, 2026 at 10:41=E2=80=AFAM Mark Johnston = wrote: >>=20 >> On Tue, Apr 21, 2026 at 09:41:31AM -0600, Alan Somers wrote: >>> On Tue, Apr 21, 2026 at 9:11=E2=80=AFAM Mark Johnston = wrote: >>>>=20 >>>> Hi, I noticed that we install pjdfstest to = /usr/tests/sys/pjdfstest, >>>> but: >>>> - it's not hooked up to the test suite, i.e., >>>> "kyua test -k /usr/tests/Kyuafile" doesn't run it, >>>> - contrib/pjdfstest doesn't seem to be updated regularly, >>>> - the configuration is hard-coded, i.e., I can't easily run it = against a >>>> filesystem of my choice. >>>>=20 >>>> How hard would it be to parameterize the tests so that we can run = the >>>> tests again a list of filesystems? For each filesystem we'd have = some >>>> little script that sets up some scratch space, creates an empty >>>> filesystem and points pjdfstest at it. In some cases we'd need the = test >>>> runner to specify some additional variables, e.g., for p9fs you = want the >>>> test runner to provide a share, as we currently only support the = virtio >>>> transport. I'm not sure if kyua can pass variables to a TAP test, = so >>>> the solution might be to wrap each pjdfstest run with an ATF test = case >>>> which handles the setup. >>>>=20 >>>> Is anyone interested in working on these things? >>>=20 >>> Yes, yes and yes. >>>=20 >>> I was indeed working on a change to pjdfstest which, among other >>> things, would read a config file for each file system under test. = The >>> config file specifies things like whether posix_fallocate is = supported >>> on that file system and which file flags are supported. The change >>> also drastically speeds up pjdfstest's runtime. >>>=20 >>> We did that as part of GSoC 2022. The status of the project is that >>> it's 99% complete, but requires somebody to comb through 4000 SLOC >>> line by line to make sure nothing got left out. That's very = tedious, >>> which is why nobody has done it yet. I would LOVE to get it = finished, >>> but I've never made the time. >>> The rewrite also relies on some ugly macro syntax. We did that >>> deliberately to save time, but it does make the code ugly, and a >>> little bit harder to review. It might be worth investing the time = to >>> rewrite those macros more cleanly. >>>=20 >>> Using the new pjdfstest, it would be quite easy to add an ATF test = for >>> each file system. atf-sh would format the file system under test, >>> then call pjdfstest with the appropriate per-filesystem config file. >>=20 >> Do you have a pointer to this work anywhere? I can't promise to >> complete it, but I'm pretty motivated to stand something up for p9fs. >=20 > It's at git@github.com:musikid/pjdfstest.git . What do you think is > the best path forward? I could publish a 0.1 release now, and get > this into ports, while you work on the ATF part. Then we could slowly > open a series of reviews that delete the old sh-based stuff. What musikid did was a good effort, but it would make pjdfstest into a = purely FreeBSD test suite since many other platforms don=E2=80=99t come = with ATF installed on them; the project currently supports Solaris (to a = lesser degree) and Linux (we still get pinged from time to time about = Linux-related support requests). -Enji= --Apple-Mail=_44BAE9A2-AC80-41C6-A611-9829BF407786 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmnnsNoACgkQGpE5DjPs NJiipw/+JqLDhbIGzY6SCtw0hwZAGtipnqvrsN0SR/f7POqnYT3ra2qlyeOT9Njb EiUltvA5ViFQoYLtZvsxSGUbb+Mqg9jwYNTNq29kPjHk5HsCqb/VjkJVRXQ0nwIh ism81ehGIixnusSyBYgwWPY8myOxsRHX2oZZ32TrSsnIgYaONyVnmeC59B6QVNKU 9qJWhYhq92qFhxlvcNwSJccGlcb8G7gkNIWS+1ehpO9Ko9KtNrLmYLe03qqCT0WS A1ncUsVbHwlV0lnG2FJCybdG2TtMd3UUnk3g2GHYT9qnFGOzGIj43y6g9njRQGEo mW+YE9dTuIGYREVsVFtSLm+tT4Ovzn+hjYfMUdedyDDXOIzE383DNepz+DVssMmo TWbFod9XKsJ20WDrHIQdZyHChbJuK4e3EBtENvjirxdbqvNsGyqUXiNYmModEo/Q sbNc3eZN/tLumkN6GMOZ64DmSFm5sJbqCT6CWlWWL5Isg2VfsdwCGEju+CqOleip lGu/bqLAC/7k8oOE9+VGBy+SkAGmmNqVgzHoNEPFTYx0ZOAp0G8Q6MubndrYrfUe ewBkegmsn9aoYmauiK7yhLHGCe4v0OiUhIDqfw3xdsSrHY/afM9AHG9PO198/HQ+ 72lrZsMeznXx46oISwpxnVAeMakGL14hXFeE7wFiNULYFCjvVVc= =7gs1 -----END PGP SIGNATURE----- --Apple-Mail=_44BAE9A2-AC80-41C6-A611-9829BF407786--