From owner-cvs-all Mon Oct 29 0:10:22 2001 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id E006D37B401; Mon, 29 Oct 2001 00:10:17 -0800 (PST) Received: from localhost (arr@localhost) by fledge.watson.org (8.11.6/8.11.5) with SMTP id f9T8A8Q35563; Mon, 29 Oct 2001 03:10:08 -0500 (EST) (envelope-from arr@watson.org) Date: Mon, 29 Oct 2001 03:10:06 -0500 (EST) From: "Andrew R. Reiter" To: Luigi Rizzo Cc: Josef Karthauser , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) In-Reply-To: <20011029000216.A95875@iguana.aciri.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 29 Oct 2001, Luigi Rizzo wrote: : :I think this is exactly the case where it makes a lot of sense to :declare vars locally to the block: the start of the function is :far away, there is a bunch of small conditionals where each :of them needs to use some temporary variable and those variables :are meant to be used only within the block. : Yes, but nevertheless, style.9 states it should be so. So unless there is a move to change style.9, it's pretty much the answer, no? Cheers, Andrew *-------------................................................. | Andrew R. Reiter | arr@fledge.watson.org | "It requires a very unusual mind | to undertake the analysis of the obvious" -- A.N. Whitehead To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message