From owner-svn-src-all@freebsd.org Sun Nov 11 01:34:18 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 82A14112396E; Sun, 11 Nov 2018 01:34:18 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 18113864C7; Sun, 11 Nov 2018 01:34:16 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 5c0a7e94; Sun, 11 Nov 2018 02:34:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=ieEzJKXThWX06C1EJqmnBf1UkHE=; b=oPXZsE+Uz9xZbREMnMzEI2IzTZTr s2cUFN7nAbSPVsRYq3dOOZdwxEThUKjUzVT3Xsy5iTUjP1fkhIN7w9MB4ZInHC+z a+sN6DW9b9D1mrWC8X1YXmoWZ9xS9oxGr6Iwiqm5AiQt41aMimaekx1XbZQUZOXO pyD/D1Ne0Jyfygo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=o/g9tRJT7tL7FvuL4m6R8hzRliw60wCxcDUYqnqqWP/t2vQ06bt9hXea D/cYfzb8gQI8S+cU1wbCSLeVCq23If3VHxjkRraEVL+AhX7OuKY0GZnW/tUC8EqK zkFPlV+aD+oKLd5Z6g+EQQSZoqkqx32Yb+fM4QvNk/07hFYCicA= Received: from skull.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 9edafea9 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Sun, 11 Nov 2018 02:34:14 +0100 (CET) Date: Sun, 11 Nov 2018 02:34:14 +0100 From: Emmanuel Vadot To: rgrimes@freebsd.org Cc: "Rodney W. Grimes" , Ben Woods , Ben Woods , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340326 - head Message-Id: <20181111023414.8431fcfee7fee7e553c020f7@bidouilliste.com> In-Reply-To: <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net> References: <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 18113864C7 X-Spamd-Result: default: False [-2.42 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com]; NEURAL_HAM_MEDIUM(-0.94)[-0.942,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:212.83.177.182/32]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[bidouilliste.com]; NEURAL_HAM_LONG(-0.98)[-0.978,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mx-backup.blih.net]; DKIM_TRACE(0.00)[bidouilliste.com:+]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_SHORT(-0.52)[-0.519,0]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(-0.07)[asn: 12876(-0.34), country: FR(-0.02)]; ASN(0.00)[asn:12876, ipnet:212.83.160.0/19, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2018 01:34:18 -0000 On Sat, 10 Nov 2018 17:07:38 -0800 (PST) "Rodney W. Grimes" wrote: > [ Charset UTF-8 unsupported, converting... ] > > On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes < > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > If your going to bother with a differential, and invite people to > > > it you should give them at least 24 hours, and preferably 72 hours > > > to respond to the new review. Reviews that last < 4 hours are not > > > code reviews. > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > Hi Rod, > > > > Sorry. The main reason I submitted the code review is because I do not have > > my src commit bit, so needed to seek approval to commit. > > All the more reason for it to wait until the people you *invited* to > the review to have a chance to respond. I don't see a problem, Ben was the one commiting r340318 and this review is just about documenting this in UPDATING. > I do not believe an "accept" in a review is an "approve to commit > beyond your normal scope". It is, see below. > Was cem aware that he was "approving a non src committer to commit > this change to the src tree" as your review has no mention that you > are seeking src bit approval to commit there. It doesn't matter, we have an implicit rule (feel free to formalized it) that if a N repo commiter accept your patch/review you are free to commit to the N repo. > > > > I felt the need to commit the UPDATING entry was time sensitive, given the > > change it was notifying users of had already been committed. > > > > Regards, > > Ben > > -- > > -- > Rod Grimes rgrimes@freebsd.org -- Emmanuel Vadot