From owner-freebsd-ports  Mon Aug 24 06:42:56 1998
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id GAA27150
          for freebsd-ports-outgoing; Mon, 24 Aug 1998 06:42:56 -0700 (PDT)
          (envelope-from owner-freebsd-ports@FreeBSD.ORG)
Received: from icc.cgu.chel.su ([195.54.14.5])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA27142
          for <ports@FreeBSD.org>; Mon, 24 Aug 1998 06:42:46 -0700 (PDT)
          (envelope-from andy@mail.cgu.chel.su)
Received: from mail.cgu.chel.su (mail.cgu.chel.su [193.125.11.33])
	by icc.cgu.chel.su (8.8.7/8.8.6) with ESMTP id TAA22017;
	Mon, 24 Aug 1998 19:42:35 +0600 (ESS)
Received: (from andy@localhost)
	by mail.cgu.chel.su (8.8.7/8.8.6) id TAA18731;
	Mon, 24 Aug 1998 19:48:34 +0600 (ESS)
From: Andrey Zakhvatov <andy@mail.cgu.chel.su>
Message-Id: <199808241348.TAA18731@mail.cgu.chel.su>
Subject: Re: do-install targets in games/*/Makefiles
In-Reply-To: <199808241108.EAA11885@silvia.hip.berkeley.edu> from Satoshi Asami at "Aug 24, 98 04:08:16 am"
To: asami@cs.berkeley.edu (Satoshi Asami)
Date: Mon, 24 Aug 1998 19:48:34 +0600 (ESS)
Cc: ports@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL32 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Hello,

> I just noticed that a lot of your Makefiles in games have a do-install
> target that uses ${INSTALL_PROGRAM} and ${INSTALL_MAN} to install a
> single binary and manpage (and sometimes the app-defaults file).  What
> is the purpose of this?
  I think it allows no-brain RightThing(tm) installation. I mean
proper handling of BINOWN, MANOWN etc. I prefer sometimes duplicate
install target of original Makefiles then track its rules for
prefixes, owners, modes etc.

> If that's the case, I don't think it's worth the complication.
> Duplicating pretty much what the original makefile already does in the 
> port makefile is not very good programming practice.
  I agree when original Makefile do the same thing _exactly_. I'll check
my ports.

> Or just forget about the whole man6 thing and just put it in section
> 1.  It's not like there are commands that both appear in section 6 and 
> 1, and most commands put the manpages in 1 anyway. ;)
  IMHO FreeBSD must be strict thing. If xquatro is game for X, then it _must_
be under ${X11BASE} (nothing else) and its man pages _must_ be under
${X11BASE}/man/man6 (nothing else). The simpliest way to reach such thing - 
just use our do-install target in port's Makefile.

  In general, I prefer _strict_ rules, determinated thing. Where man page
of X Window game must be? Answer, IMHO, must be without variants.

P.S. Of course, port's Makefile must allow redefinition of PREFIX for
test/private installation, but for system-wide installation all things
must be determinatable.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message