Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 03 Dec 2012 10:46:29 +0100
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/174082: [PATCH] misc/gonvert: OptionsNG, added license, changed comment, NLS, take maintainership
Message-ID:  <20121203094632.EFF34910@hub.freebsd.org>
Resent-Message-ID: <201212030950.qB39o1p0023376@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         174082
>Category:       ports
>Synopsis:       [PATCH] misc/gonvert: OptionsNG, added license, changed comment, NLS, take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 03 09:50:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC
>Description:
- Take maintainership

Makefile changed:
+COMMENT=
+LICENSE=	GPLv2
+PORTDOCS=
+.include <bsd.port.options.mk>
+.if ${PORT_OPTIONS:MNLS}
+.if ${PORT_OPTIONS:MDOCS}

Changed and refined:
 pkg-descr
 pkg-plist

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

portlint -A
looks fine.

port test: clean

>Fix:

--- gonvert-0.2.25_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/misc/gonvert/Makefile ./Makefile
--- /usr/ports/misc/gonvert/Makefile	2012-11-16 09:03:14.000000000 +0100
+++ ./Makefile	2012-12-03 10:37:43.000000000 +0100
@@ -8,18 +8,30 @@
 
 PORTNAME=	gonvert
 PORTVERSION=	0.2.25
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	misc python gnome
 MASTER_SITES=	http://www.unihedron.com/projects/gonvert/downloads/
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A conversion utility that allows conversion between many units
+MAINTAINER=	nemysis@gmx.ch
+COMMENT=	Conversion utility that allows conversion between many units
+
+LICENSE=	GPLv2
 
 USE_GNOME=	pygtk2
 USE_PYTHON=	yes
-USE_GETTEXT=	yes
 NO_BUILD=	yes
 
+PORTDOCS=	CHANGELOG FAQ README THANKS TODO
+
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MNLS}
+USE_GETTEXT=	yes
+PLIST_SUB+=	NLS=""
+.else
+PLIST_SUB+=	NLS="@comment "
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|#!/usr/bin/python|#!/usr/bin/env python|g ; \
 		 s|/usr/share|${PREFIX}/share|g ; \
@@ -35,14 +47,16 @@
 	${INSTALL_DATA} ${WRKSRC}/pixmaps/*.png ${DATADIR}/pixmaps
 	@${MKDIR} ${PREFIX}/share/pixmaps
 	${LN} -sf ${DATADIR}/pixmaps/gonvert.png ${PREFIX}/share/pixmaps
+
+.if ${PORT_OPTIONS:MNLS}
 	@${MKDIR} ${PREFIX}/share/locale/pl/LC_MESSAGES
 	${INSTALL_DATA} ${WRKSRC}/i18n/pl_messages.gmo \
 		${PREFIX}/share/locale/pl/LC_MESSAGES/gonvert.mo
-.if !defined(NOPORTDOCS)
+.endif
+
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
-.for file in CHANGELOG FAQ README THANKS TODO
-	${INSTALL_DATA} ${WRKSRC}/doc/${file} ${DOCSDIR}
-.endfor
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/doc/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
diff -ruN --exclude=CVS /usr/ports/misc/gonvert/pkg-descr ./pkg-descr
--- /usr/ports/misc/gonvert/pkg-descr	2012-11-16 09:03:14.000000000 +0100
+++ ./pkg-descr	2012-12-03 10:34:01.000000000 +0100
@@ -1,15 +1,16 @@
 gonvert is a conversion utility that allows conversion between many units
-like CGS, Ancient, Imperial with many categories like length, mass,
-numbers, etc. All units converted values shown at once as you type. Easy
-to add/change your own units.
+like CGS, Ancient, Imperial with many categories like length, mass, numbers,
+etc. All units converted values shown at once as you type. Easy to add/change
+your own units.
 
 Features:
 
-   - 38 categories, 698 units.
-   - All units converted values shown at once as you type. 
-   - Descriptions for many units. 
-   - Sort Units or values. 
-   - Fully OPEN source so that you can add your own custom calculations
-     and descriptions. 
+    - 51 categories, 981 units. See the entire list here.
+    - All units converted values shown at once as you type.
+    - Descriptions for many units.
+    - Sort by Unit Name, Value, or Unit symbol.
+    - Find Units.
+    - Fully OPEN source so that you can add your own custom calculations
+      and descriptions.
 
 WWW: http://www.unihedron.com/projects/gonvert/
diff -ruN --exclude=CVS /usr/ports/misc/gonvert/pkg-plist ./pkg-plist
--- /usr/ports/misc/gonvert/pkg-plist	2012-11-16 09:03:14.000000000 +0100
+++ ./pkg-plist	2012-12-03 10:20:54.000000000 +0100
@@ -1,16 +1,10 @@
 bin/gonvert
 share/applications/gonvert.desktop
-%%PORTDOCS%%%%DOCSDIR%%/CHANGELOG
-%%PORTDOCS%%%%DOCSDIR%%/FAQ
-%%PORTDOCS%%%%DOCSDIR%%/README
-%%PORTDOCS%%%%DOCSDIR%%/THANKS
-%%PORTDOCS%%%%DOCSDIR%%/TODO
 %%DATADIR%%/gonvert.glade
-%%DATADIR%%/pixmaps/gonvert.png
 %%DATADIR%%/pixmaps/gonvert-icon_alternative.png
-share/locale/pl/LC_MESSAGES/gonvert.mo
+%%DATADIR%%/pixmaps/gonvert.png
+%%NLS%%share/locale/pl/LC_MESSAGES/gonvert.mo
 share/pixmaps/gonvert.png
 @dirrm %%DATADIR%%/pixmaps
 @dirrm %%DATADIR%%
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
 @dirrmtry share/applications
--- gonvert-0.2.25_2.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121203094632.EFF34910>