From owner-cvs-all Mon Nov 19 14: 1: 9 2001 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 16ADD37B417; Mon, 19 Nov 2001 14:01:03 -0800 (PST) Received: from localhost (arr@localhost) by fledge.watson.org (8.11.6/8.11.5) with SMTP id fAJM0q676511; Mon, 19 Nov 2001 17:00:52 -0500 (EST) (envelope-from arr@FreeBSD.org) X-Authentication-Warning: fledge.watson.org: arr owned process doing -bs Date: Mon, 19 Nov 2001 17:00:51 -0500 (EST) From: "Andrew R. Reiter" X-Sender: arr@fledge.watson.org To: Yar Tikhiy Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/ftpd ftpd.c In-Reply-To: <200111192152.fAJLq3N94389@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 19 Nov 2001, Yar Tikhiy wrote: :yar 2001/11/19 13:52:03 PST : : Modified files: : libexec/ftpd ftpd.c : Log: : Eliminate another instance of the old and well-known : DoS bug that the select(2)/accept(2) pair is called on : a socket that is in the blocking I/O mode. The bug is : triggered if a selected connection dies before the accept(2) : leading to the accept(2) blocking virtually forever. : : MFC after: 1 week : : Revision Changes Path : 1.87 +25 -7 src/libexec/ftpd/ftpd.c Just as a thought, since I've noted the ftpd mucking, there are two issues with the ftp daemon code that are not necesarily critical, but should be changed: - Dynamically allocate the fd_set bit arrays - Correct usage of signal handlers to only use set/check flags. Got anymore motivation to tackle those? Cheers, Andrew -- Andrew R. Reiter arr@watson.org arr@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message