From owner-svn-src-head@freebsd.org Tue Jan 3 10:26:28 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA4CFC9D2E7; Tue, 3 Jan 2017 10:26:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F7BF1D31; Tue, 3 Jan 2017 10:26:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v03AQMAP056058 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 3 Jan 2017 12:26:22 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v03AQMAP056058 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v03AQMVj056057; Tue, 3 Jan 2017 12:26:22 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 3 Jan 2017 12:26:22 +0200 From: Konstantin Belousov To: Pedro Giffuni Cc: Conrad Meyer , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311109 - head/usr.bin/patch Message-ID: <20170103102622.GO1923@kib.kiev.ua> References: <201701021823.v02INWXc028047@repo.freebsd.org> <9c3fc378-ee5e-19ba-c286-1440d4b13615@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c3fc378-ee5e-19ba-c286-1440d4b13615@FreeBSD.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 10:26:28 -0000 On Mon, Jan 02, 2017 at 07:41:26PM -0500, Pedro Giffuni wrote: > > > On 01/02/17 17:54, Conrad Meyer wrote: > > I was suggesting using UINT32_MAX/2 on all platforms (which is safe > > everywhere). > > > > Ah OK. INT_MAX is ~ (UINT_MAX / 2) so it's the same to use either. > I just think it's clearer to use INT_MAX and the corresponding int > type. > > The other issue is if diff(1) can handle such lines(?). Of course it cannot, on ILP32 arches.