From owner-freebsd-multimedia@FreeBSD.ORG Sun Sep 18 19:00:33 2011 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E6B6A1065670; Sun, 18 Sep 2011 19:00:33 +0000 (UTC) (envelope-from nox@jelal.kn-bremen.de) Received: from smtp.kn-bremen.de (gelbbaer.kn-bremen.de [78.46.108.116]) by mx1.freebsd.org (Postfix) with ESMTP id A05C38FC0A; Sun, 18 Sep 2011 19:00:33 +0000 (UTC) Received: by smtp.kn-bremen.de (Postfix, from userid 10) id 8AA381E0023E; Sun, 18 Sep 2011 21:00:32 +0200 (CEST) Received: from triton8.kn-bremen.de (noident@localhost [127.0.0.1]) by triton8.kn-bremen.de (8.14.4/8.14.3) with ESMTP id p8IIulQ2028995; Sun, 18 Sep 2011 20:56:47 +0200 (CEST) (envelope-from nox@triton8.kn-bremen.de) Received: (from nox@localhost) by triton8.kn-bremen.de (8.14.4/8.14.3/Submit) id p8IIulfs028994; Sun, 18 Sep 2011 20:56:47 +0200 (CEST) (envelope-from nox) From: Juergen Lock Date: Sun, 18 Sep 2011 20:56:47 +0200 To: bf1783@gmail.com Message-ID: <20110918185647.GA28605@triton8.kn-bremen.de> References: <20110918152101.GA88715@triton8.kn-bremen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-multimedia@freebsd.org, gerald@freebsd.org, Juergen Lock Subject: Re: Has anyone tested the jack update - am I ok to commit it? X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Sep 2011 19:00:34 -0000 On Sun, Sep 18, 2011 at 12:07:50PM -0400, b. f. wrote: > On 9/18/11, Juergen Lock wrote: > > On Sat, Sep 17, 2011 at 10:19:27PM -0400, b. f. wrote: > > >> -- clean up ugly flag handling > >> > > Can you elaborate? > > As in the patch I sent to you, along with the doxygen-related changes. Hm that never arrived here. :( (Or did you send it to a list only? Then I missed it.) > CFLAGS and CPPFLAGS are already being passed in do-configure, so it > is only necessary to append to them, but not to explicitly add them to > CONFIGURE_ENV. This also makes it easier to check their values via > "make -V". Also, it was always advisable to perform linking via the > compiler with the flags issued for compilation, and now it is > essential for flags like -flto and -fstack-protector, which some > people are using with ports, so our previous careless handling of > LDFLAGS is being cleaned up (cf. > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=ports/157936, etc.) , and > it is important to try (within reason) to honor the user-requested > LDFLAGS just as we do for CFLAGS. Therefore, just append the addition > to the library search path to LDFLAGS, and pass the result, rather > than clobbering the flags. Anyway, you are right, that should be cleaned up. I have now made a new update including your suggestions and tested it with ardour3 again: http://people.freebsd.org/~nox/tmp/jack-0.121.2.patch The jack_get_microseconds() code I added to files/patch-drivers-oss-oss_driver.c may not be the best solution, I added it to fix a segfault at jackd start because driver->engine was NULL in oss_driver_start()... Thanx for testing, :) Juergen