Date: Sun, 26 Feb 2017 17:51:40 -0800 From: Cy Schubert <Cy.Schubert@komquats.com> To: "Pedro F. Giffuni" <pfg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314322 - head/lib/librss Message-ID: <201702270151.v1R1pe1F003587@slippy.cwsent.com> In-Reply-To: Message from "Pedro F. Giffuni" <pfg@FreeBSD.org> of "Mon, 27 Feb 2017 00:10:01 %2B0000." <201702270010.v1R0A1wm074123@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <201702270010.v1R0A1wm074123@repo.freebsd.org>, "Pedro F. Giffuni" w rites: > Author: pfg > Date: Mon Feb 27 00:10:00 2017 > New Revision: 314322 > URL: https://svnweb.freebsd.org/changeset/base/314322 > > Log: > librss: simplify some NULL checks. > > MFC after: 1 week > > Modified: > head/lib/librss/librss.c > > Modified: head/lib/librss/librss.c > ============================================================================= > = > --- head/lib/librss/librss.c Sun Feb 26 22:17:06 2017 (r314321) > +++ head/lib/librss/librss.c Mon Feb 27 00:10:00 2017 (r314322) > @@ -244,10 +244,10 @@ rss_config_get(void) > return (rc); > > error: > - if ((rc != NULL) && rc->rss_bucket_map) > + if (rc != NULL) { > free(rc->rss_bucket_map); What happens if rc is not NULL and rc->rss_bucket_map is NULL? > - if (rc != NULL) > free(rc); > + } > return (NULL); > } > > > -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702270151.v1R1pe1F003587>