From owner-cvs-usrsbin Thu May 11 01:33:17 1995 Return-Path: cvs-usrsbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id BAA20329 for cvs-usrsbin-outgoing; Thu, 11 May 1995 01:33:17 -0700 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id BAA20318 ; Thu, 11 May 1995 01:33:06 -0700 Received: from Root.COM (implode.Root.COM [198.145.90.1]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id BAA00271; Thu, 11 May 1995 01:32:43 -0700 Received: from corbin.Root.COM (corbin.Root.COM [198.145.90.18]) by Root.COM (8.6.8/8.6.5) with ESMTP id BAA06709; Thu, 11 May 1995 01:35:55 -0700 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.11/8.6.5) with SMTP id BAA01861; Thu, 11 May 1995 01:32:54 -0700 Message-Id: <199505110832.BAA01861@corbin.Root.COM> To: Bruce Evans cc: CVS-commiters@time.cdrom.com, cvs-usrsbin@time.cdrom.com, jkh@time.cdrom.com Subject: Re: cvs commit: src/usr.sbin/config mkioconf.c In-reply-to: Your message of "Thu, 11 May 95 18:22:07 +1000." <199505110822.SAA11481@godzilla.zeta.org.au> From: David Greenman Reply-To: davidg@Root.COM Date: Thu, 11 May 1995 01:32:49 -0700 Sender: cvs-usrsbin-owner@freebsd.org Precedence: bulk >> Modified: usr.sbin/config mkioconf.c >> Log: >> Revise this to actually print all the various isa_device field values >> it really should have been printing all this time. Also fix my rather >> bogus handling of the id_conflicts value by moving it to the end of >> isa_device and dealing with that correctly now. > >id_conflicts was in the right place before. id_enabled is in the wrong >place (at the end). None of the internal (initially 0) fields should be >printed, but putting id_enabled at the end messed this up. Internal >pointer fields such as id_next can't possibly be printed. I don't think I agree. I think it is rather bogus to generate an initialized structure that is only partially initialized. -DG