Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Apr 2021 21:50:18 +0200
From:      Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
To:        freebsd-fs@freebsd.org
Subject:   [struct mount] Outdated locking documentation for mnt_uppers
Message-ID:  <53c970ad-bd87-5d7b-8a6c-4e526d96b93b@tu-dortmund.de>

next in thread | raw e-mail | index | archive | help
Hi folks,

I came accross the locking documentation for struct mount.
According to the definition [1], mnt_uppers should be accessed using the 
global mountlist_mtx.
However, the code uses the MNT_ILOCK macro, which uses the mnt_mtx.
Is the locking documentation still valid?
Shouldn't it be updated?

Regards,
Alex

[1] https://github.com/freebsd/freebsd-src/blob/main/sys/sys/mount.h#L246
-- 
Technische Universität Dortmund
Alexander Lochmann                PGP key: 0xBC3EF6FD
Otto-Hahn-Str. 16                 phone:  +49.231.7556141
D-44227 Dortmund                  fax:    +49.231.7556116
http://ess.cs.tu-dortmund.de/Staff/al



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53c970ad-bd87-5d7b-8a6c-4e526d96b93b>