From owner-cvs-all@FreeBSD.ORG Sun Jun 12 22:46:40 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A181216A41C; Sun, 12 Jun 2005 22:46:40 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 401FC43D1D; Sun, 12 Jun 2005 22:46:37 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14]) (authenticated bits=0) by pooker.samsco.org (8.13.3/8.13.3) with ESMTP id j5CMpbsx099326; Sun, 12 Jun 2005 16:51:37 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <42ACBADB.70109@samsco.org> Date: Sun, 12 Jun 2005 16:44:43 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jeff Roberson References: <200506122232.j5CMWTIb020093@repoman.freebsd.org> In-Reply-To: <200506122232.j5CMWTIb020093@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_disk.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jun 2005 22:46:40 -0000 Jeff Roberson wrote: > jeff 2005-06-12 22:32:29 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_disk.c > Log: > - Dramatically simplify bioqdisksort(). We no longer do ordered bios so > most of the code to deal with them has been dead for sometime. Simplify > the code by doing an insert sort hinted by the current head position. > > Met with apathy by: arch@ > > Revision Changes Path > 1.84 +40 -85 src/sys/kern/subr_disk.c Not exactly apathy, just lack of time ;-( I trust that this has been adequately tested on many different workloads? Also, how exactly does this fall under your blanket approval to fix VFS? Scott