From owner-svn-src-head@freebsd.org Sat Mar 4 20:42:58 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77A73CF9160; Sat, 4 Mar 2017 20:42:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 45BA51AD9; Sat, 4 Mar 2017 20:42:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x241.google.com with SMTP id x66so13268167pfb.1; Sat, 04 Mar 2017 12:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=agwYENuahehvun0vfrih/Jc/zAClbgMLq8Wjgdtl7ZM=; b=Aup0INZS68inFw66uCllgWh4JE4EAhzmObKt96+Wq2ekEvlHkLKoZ+u7OzHfW2f3el nq4wNt2P3GG0tkDrHvHOZKE2tR1+rPwdqU5B4869W9LoCvUzf4u5CNbc85JfaWsPRW90 bN+jz27KMVN/2ZPHHTCCfzLuvJfnarQwRx1jkeORYfWrNPflL8T2B+KAyz28Gj6uupwe f24Lzr1kx7Molg4/l4iHKo7+X/3HydGCuB/exzEc7VKnMtxy/izdhxOfyAJy2+DfO7i0 EoYJXwAx2pQYcbN08/jxvWgn/uskeZq+KVmhSXs6I79T23DwazCDwaL3zK8avEEIcsEE N7sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=agwYENuahehvun0vfrih/Jc/zAClbgMLq8Wjgdtl7ZM=; b=hYX0xvl1sjNpmJomVaEh833dQWmx3e4A+WuoQQa89oHqPxsAWz/Tt8sBdtnn2TK5lq PlnZBcjVY6U2/cvNaXOASfNFY4iCKRLOZwxJ2BucRjSJI7sYxoDQwD4tPpIbSyF1NLGK 9Ezj+9mTdiBy5Aiovvxm6ARd3aiNjCdnb/UgxfdwbJloV9mOQrenRfs8jigBtAgYt+DP kmIqfp8/ujluX9H3vw+Qhd5PeAB/+xwp2mR4ybiAqjLUJMN7Gzf6SHnr6Eu94URll3eB wCC2P6WTBMq/tenS0cuKawKpd9zJgJ5ZXXtP/KYYHz793Cv/7eX2EQuh+v9Nfsw2Chzg nrDQ== X-Gm-Message-State: AMke39nACnCbAx4UDljwUxpnhHBIaLKzjnrZZ+OoDH0SDdquNRio6Bcr71sayxrZHsuKrw== X-Received: by 10.84.216.17 with SMTP id m17mr14316502pli.158.1488660177602; Sat, 04 Mar 2017 12:42:57 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id u80sm30875932pgb.32.2017.03.04.12.42.56 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 04 Mar 2017 12:42:56 -0800 (PST) Subject: Re: svn commit: r314654 - in head/cddl: lib/drti lib/libavl lib/libctf lib/libdtrace lib/libnvpair lib/libumem lib/libuutil lib/libzfs lib/libzfs_core lib/libzpool sbin/zfs sbin/zpool usr.bin/ctfconver... Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_B9219893-DECE-4180-A18C-1071A263127C"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201703042039.v24KdcDE078734@pdx.rh.CN85.dnsmgr.net> Date: Sat, 4 Mar 2017 12:42:56 -0800 Cc: Bryan Drewery , Ngie Cooper , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Message-Id: <03156186-221F-4EEB-A86E-077E46E28296@gmail.com> References: <201703042039.v24KdcDE078734@pdx.rh.CN85.dnsmgr.net> To: rgrimes@FreeBSD.org X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 20:42:58 -0000 --Apple-Mail=_B9219893-DECE-4180-A18C-1071A263127C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 4, 2017, at 12:39, Rodney W. Grimes = wrote: >=20 > -- Start of PGP signed section. > [ Charset windows-1252 unsupported, converting... ] >> On 3/4/2017 7:20 AM, Rodney W. Grimes wrote: >>> [ Charset UTF-8 unsupported, converting... ] >>>> Author: ngie >>>> Date: Sat Mar 4 11:30:04 2017 >>>> New Revision: 314654 >>>> URL: https://svnweb.freebsd.org/changeset/base/314654 >>>>=20 >>>> Log: >>>> cddl: normalize paths using SRCTOP-relative paths or :H when = possible >>>>=20 >>>> This simplifies make logic/output >>>>=20 >>>> While here, remove bogus CFLAGS which look for headers in = cddl/lib/libumem. >>>> There aren't any source files there (just Makefiles) >>> Please again, dont intermingle other chnages when doing a tree wide = sweep. >>>=20 >>> IMHO if you write While here, you probably should do that thing in a >>> seperate commit, unless this is a single thing your touching in a = single >>> commit. >>>=20 >>> It is much easier to glue 2 commits togeather than seperate 1 that >>> changes 2 things. >>>=20 >>=20 >> Agreed. There were also various comment changes in here. This is = why >> git is nice, you can git add -p and stage multiple commits before >> pushing. git-svn handles this fine. >>=20 >>>=20 >>> It is also still not clear to me that this was adeqautly disccussed = as I >>> only saw 2 +'s for staying relative and no one +ing to move forward = with this. >>=20 >> Where is this discussion? The only one I can find is >> https://reviews.freebsd.org/D9207 which seems to have a consensus of >> moving to SRCTOP and :H vs '../..'. >=20 > There was a short discussion here on the commiters list with some = others > expressing the prefered the relative status of things even though it > clutters logs. >=20 > D9207 touches 15 files.. I would not consider that an adaquate review = that > is actually going to change near every Makefile in the tree, and = change what > people have been looking and at working with for 30 years. >=20 > I dont think any differntial that only had 3 or 4 people involed that > is going to effect all developers is adaquate either. Tree wide = sweeping > changes should be discussed far more widely. >=20 > Idk, maybe I am to personally attached to the relative paths.. cause I > had a major part in helping them all to work, or perhaps its my been > burned by absolute paths that had to be reworked too many times in > my past. But my gutt is telling me this change is Bad(tm). I care about this for the reasons brewery posted, but I also care = because it slows down my terminal output and it bloats my disk with = typescript logs that contain unnecessary information. I agree, the :H .CURDIR bits that could have been done with SRCTOP were = potentially careless -- I was trying to keep things local to components = in the src tree. I=E2=80=99ll go back and fix them if enough people come = at me with pitchforks :(. -Ngie --Apple-Mail=_B9219893-DECE-4180-A18C-1071A263127C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYuybQAAoJEPWDqSZpMIYVjs4QALh+l5qR5l8p5cBiLrebYtjb UEm2M+f3AWuyeSZXHl4SpB6v9IipgfQRM1yo3je5QwiSHA/hm6vynW/vHObpS0vc ijNnt+kvRa4k2+mzDNjdg5QO/dIIl8bKqq0ZUqw9XlKm/aVx92XpIOp8iocXxShC 8a4TMMB9Y4eRcDZ2j3McZ5sWKSzmChbHrKE8X8KSXXdZUIpNJtwULzGgFlymfLsl USKL2lrRTrEK3LIjU5D10NsUuDIGeaY2B1zScKSZt0sACue43FKQfIeZaaHvMP50 Bt5OkARxu0PvWdK3fcMD5WrgO2QLh/2Y0Wl+RRM5MzZ9FiZaXWvDJ7lr6mqPMQtN cyYIbhIOGawTGUHUfUCswVYENVgvCPaF4T4qvtEelKiHHbm6ueyaVn3vDTByU3Zc O3Yrtz9WpNBspQ9NVg1vUuXdP/TnZbGk+rdLV/RjySfBDrqbUqBMofwQcyPEbCyq NvOTLtn96D4eMDOLsTse6dK1ZJ9c3ogA60fENPHQzSIVl//vGqeyg4nZ5g4H9gT7 7MvBt2yys51CuTnFrdhso1aqMeTbHM9XtnnTivT4GUUdv6xwRR1BEZhIMQWQDWZh iAUhORRkyymd9Afzap+Nq1ZzXO4oxrj1bFCDtopW7gu4b1R4DTPvNeppkODRxsmE C8h9y0wp4O3tdawIE/Hl =gYq8 -----END PGP SIGNATURE----- --Apple-Mail=_B9219893-DECE-4180-A18C-1071A263127C--