From owner-svn-src-all@freebsd.org Fri Sep 23 20:03:14 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37A5CBE8630; Fri, 23 Sep 2016 20:03:14 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C97BB10E4; Fri, 23 Sep 2016 20:03:13 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm0-x244.google.com with SMTP id 133so4350859wmq.2; Fri, 23 Sep 2016 13:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cOkybFQWujD2r4eKS+Ajcfhr0YkVaiaLVvrChZVvM3g=; b=AsuTwDXI5Mr3S4T/ZmKIr6VR1fIYH7iCweJ1rvzVUpzPaIO9kgG3nxxl/pskdh8tkO ClzpLwCS6fqINM/ZDMoaw1Lc4q5WQvOrhJS1RGB0/FvTYhsGvKn8BO3sqUODPIBQIllZ yAOBmwJF5udpBU9xOFbbc8dEgelqN6JesljnfA4OQXqTjax96+wjZ3qpLW/6w3g7EKxE EWzBlGQ7oCthPXvFrs/orsh6LpXeGb29vRsI2bqcqHu2L+nJukGrLbh79RrDbZ075ezf /B+s8MvVT8VuSX4+4R3Rj0WGsDtp2kdzbRF40j0cSNCJ+MSDg4PtUS9ccnUc93Kklt+/ 4CCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cOkybFQWujD2r4eKS+Ajcfhr0YkVaiaLVvrChZVvM3g=; b=JhCIiE5iNv1xIJ8KM43jqDNqCPQRcIsVwlmFiRTlOhV1K0jd2VLpsFG6LXd/QCbWHk 4WuGOQsJ2Xt4bSJj0JPrM+8djWQHW/o1CmO/BoOEMcDivhJKavQNHXIDdonlb3+Ny8Hr +jUWUtrkDDk7VYcVZo05YWoRi1L3vqMWt/B6BKzx69ZZLQRbzRjC+EHyY7dJMHUNAj/w wQhTAGd1IjOpnvWtVTshAiBPW2QWpjLL8dKfZjJDoE8p168nJhlA8guCgb1eppoVPjV4 vIiht89FrWrt3c3NVJGjkKXGvD7lvP+9L03T4Sqik0EfuMWHAsBD/jUNxiJd7eFIqeVT 4uvw== X-Gm-Message-State: AA6/9RknLB7rycmWUWfHOjTMH+p4AbyDdP+6Jtiyie88NWsBcLgcuHmiY3y42DVt1P0EcQ== X-Received: by 10.28.39.133 with SMTP id n127mr4781777wmn.6.1474660990865; Fri, 23 Sep 2016 13:03:10 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id d64sm5582467wmh.0.2016.09.23.13.03.09 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 23 Sep 2016 13:03:10 -0700 (PDT) Date: Fri, 23 Sep 2016 22:03:08 +0200 From: Mateusz Guzik To: Andreas Tobler Cc: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306272 - head/sys/sys Message-ID: <20160923200308.GB25423@dft-labs.eu> References: <201609231647.u8NGlCYF045234@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2016 20:03:14 -0000 On Fri, Sep 23, 2016 at 09:59:32PM +0200, Andreas Tobler wrote: > On 23.09.16 18:47, Mateusz Guzik wrote: > >Author: mjg > >Date: Fri Sep 23 16:47:12 2016 > >New Revision: 306272 > >URL: https://svnweb.freebsd.org/changeset/base/306272 > > > >Log: > > fd: hide fd_modified under CAPABILITIES > > > > It has no use without it and is now less error prone. > > > >Modified: > > head/sys/sys/filedesc.h > > > >Modified: head/sys/sys/filedesc.h > >============================================================================== > >--- head/sys/sys/filedesc.h Fri Sep 23 16:22:03 2016 (r306271) > >+++ head/sys/sys/filedesc.h Fri Sep 23 16:47:12 2016 (r306272) > >@@ -229,12 +229,14 @@ fdeget_locked(struct filedesc *fdp, int > > return (fde); > > } > > > >+#ifdef CAPABILITIES > > static __inline bool > > fd_modified(struct filedesc *fdp, int fd, seq_t seq) > > { > > > > return (!seq_consistent(fd_seq(fdp->fd_files, fd), seq)); > > } > >+#endif > > > > /* cdir/rdir/jdir manipulation functions. */ > > void pwd_chdir(struct thread *td, struct vnode *vp); > > I think this breaks kernel builds: > > /usr/src/sys/modules/cloudabi/../../compat/cloudabi/cloudabi_fd.c:482:14: > error: implicit declaration of function 'fd_modified' is invalid in > C99 [-Werror,-Wimplicit-function-declaration] > modified = fd_modified(fdp, uap->fd, seq); > ^ > 1 error generated. > *** [cloudabi_fd.o] Error code 1 > Ye indeed, I hacked up a fix: https://people.freebsd.org/~mjg/patches/cloudabi-fd_modified.diff if ed@ does not respond soon acking the patch, I'll temporarily reviert this change. -- Mateusz Guzik