From owner-svn-ports-head@freebsd.org  Sat Feb 11 16:03:19 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C207CDB47C;
 Sat, 11 Feb 2017 16:03:19 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5E5DADDB;
 Sat, 11 Feb 2017 16:03:19 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id A6D1F3E33; Sat, 11 Feb 2017 16:03:18 +0000 (UTC)
To: mmokhi@FreeBSD.org, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r433881 - in head/sysutils: . lttng-tools
 lttng-tools/files lttng-ust lttng-ust/files
In-Reply-To: <201702111536.v1BFaI3i033986@repo.freebsd.org>
Message-Id: <20170211160318.A6D1F3E33@freefall.freebsd.org>
Date: Sat, 11 Feb 2017 16:03:18 +0000 (UTC)
From: jbeich@freebsd.org (Jan Beich)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Feb 2017 16:03:19 -0000

Mahdi Mokhtari <mmokhi@FreeBSD.org> writes:

> + 	char tmp_path[PATH_MAX];
> ++#if defined(__FreeBSD__)
> ++	const size_t HOST_NAME_MAX = sysconf(_SC_HOST_NAME_MAX);
> ++#endif
> + 	char hostname[HOST_NAME_MAX];
[...]
> + struct ltt_session {
> + 	char name[NAME_MAX];
> ++#if defined(__FreeBSD__)
> ++	char hostname[256]; /* Local hostname. */
> ++#else
> + 	char hostname[HOST_NAME_MAX]; /* Local hostname. */
> ++#endif

Why do you mix constant and sysconf() usage?

> + #if (defined(__FreeBSD__) || defined(__CYGWIN__))
> + typedef long long off64_t;
> + #endif

FreeBSD 11.0 or later define off64_t as an alias for off_t aka int64_t
which is "long" (not "long long") on amd64. Is the conflicting
definition intentional?