From owner-cvs-src@FreeBSD.ORG  Mon Jun  9 15:42:52 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9371637B401; Mon,  9 Jun 2003 15:42:52 -0700 (PDT)
Received: from rwcrmhc12.attbi.com (rwcrmhc12.attbi.com [216.148.227.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E211343FB1; Mon,  9 Jun 2003 15:42:51 -0700 (PDT)
	(envelope-from julian@elischer.org)
Received: from interjet.elischer.org ([12.232.168.4])
          by attbi.com (rwcrmhc12) with ESMTP
          id <2003060922425001400ab3qme>; Mon, 9 Jun 2003 22:42:51 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id PAA49859;
	Mon, 9 Jun 2003 15:42:49 -0700 (PDT)
Date: Mon, 9 Jun 2003 15:42:47 -0700 (PDT)
From: Julian Elischer <julian@elischer.org>
To: Nate Lawson <nate@root.org>
In-Reply-To: <20030609153323.G36983@root.org>
Message-ID: <Pine.BSF.4.21.0306091541100.46920-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Poul-Henning Kamp <phk@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm uma_core.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jun 2003 22:42:53 -0000



On Mon, 9 Jun 2003, Nate Lawson wrote:

> On Mon, 9 Jun 2003, Poul-Henning Kamp wrote:
> >   A white-space nit I noticed.
> >
> >   Revision  Changes    Path
> >   1.56      +1 -1      src/sys/vm/uma_core.c
> >
> > --- src/sys/vm/uma_core.c:1.55	Sun Apr 27 23:11:32 2003
> > +++ src/sys/vm/uma_core.c	Mon Jun  9 12:40:34 2003
> > @@ -1843,7 +1843,7 @@
> >
> >  	/* Do we need to remove from any lists? */
> >  	if (slab->us_freecount+1 == zone->uz_ipers) {
> > -		LIST_REMOVE(slab, us_link);
> > +		LIST_REMOVE(slab,us_link);
> >  		LIST_INSERT_HEAD(&zone->uz_free_slab, slab, us_link);
> >  	} else if (slab->us_freecount == 0) {
> >  		LIST_REMOVE(slab, us_link);
> 
> Is that correct style to remove the space after the comma?  The former way
> seems more correct.  Also, it differs from the LIST_REMOVE immediately
> after.

I am guessing a patch applied backwards or something..
I'm sure that's not what he inteded :-)

> 
> -Nate
>