From owner-freebsd-gnome@FreeBSD.ORG Sat Jul 2 04:46:08 2005 Return-Path: X-Original-To: gnome@FreeBSD.org Delivered-To: freebsd-gnome@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CEE416A41C for ; Sat, 2 Jul 2005 04:46:08 +0000 (GMT) (envelope-from marcus@FreeBSD.org) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 392FA43D1F for ; Sat, 2 Jul 2005 04:46:08 +0000 (GMT) (envelope-from marcus@FreeBSD.org) Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4]) by creme-brulee.marcuscom.com (8.13.3/8.13.3) with ESMTP id j624kASc025270; Sat, 2 Jul 2005 00:46:10 -0400 (EDT) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: Vladimir Chukharev In-Reply-To: References: <1120162303.36495.6.camel@shumai.marcuscom.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-HLuPRLa5F8jtnscKOWql" Organization: FreeBSD, Inc. Date: Sat, 02 Jul 2005 00:45:47 -0400 Message-Id: <1120279547.45944.6.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 FreeBSD GNOME Team Port Cc: gnome@FreeBSD.org Subject: Re: HEADS UP: Realtime update support added to battstat X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jul 2005 04:46:08 -0000 --=-HLuPRLa5F8jtnscKOWql Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2005-07-02 at 00:28 +0300, Vladimir Chukharev wrote: > On Thu, 30 Jun 2005 23:11:43 +0300, Joe Marcus Clarke wrote: >=20 > > I went through the code again, but I did not see any obvious file > > descriptor leaks. I did, however, find a few other bugs. I've posted = a > > new version of the battstat patch at > > http://www.marcuscom.com/downloads/patch-battstat-acpi. Please try thi= s > > new version, and if you see those maxfiles messages again, get the > > output of lsof for the battstat process (i.e. lsof -p > battstat-applet-2>). >=20 > I put this patch instead of /usr/ports/x11/gnomeapplets2/files/patch-batt= stat-acpi > reinstalled the port and added the Battery Monitor to a panel. > then I ran lsof -p on it a few times. Each time the result was longer > and longer, the lines with /dev/acpi were multiplying... > I did not wait till I run out of maxfiles limit, just removed > the monitor. >=20 > Result of one of the lsof runs is attached. Ah! I was looking for a devd file descriptor leak. I completely forgot about /dev/acpi. The fact that you're running into this leak means you're probably not connecting to devd.pipe correctly. Check the perms on /var/run/devd.pipe to make sure they're 0666. However, I have fixed the leak, and a new patch is up at http://www.marcuscom.com/downloads/patch-battstat-acpi. Joe >=20 > --=20 > V.Chukharev --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-HLuPRLa5F8jtnscKOWql Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBCxhv7b2iPiv4Uz4cRAsDZAKCAA4110NHn0AP9Alkxq3EUdFC7SgCeJe98 A/jdSaxK36DKZtY3cMRCx2I= =IU5l -----END PGP SIGNATURE----- --=-HLuPRLa5F8jtnscKOWql--