From owner-freebsd-ports@FreeBSD.ORG  Wed Jun  2 06:40:10 2004
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1D9E916A4CE
	for <ports@FreeBSD.org>; Wed,  2 Jun 2004 06:40:10 -0700 (PDT)
Received: from fillmore.dyndns.org (port-212-202-49-130.dynamic.qsc.de
	[212.202.49.130])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D474C43D54
	for <ports@FreeBSD.org>; Wed,  2 Jun 2004 06:40:09 -0700 (PDT)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from [172.16.0.2] (helo=fillmore-labs.com)
	by fillmore.dyndns.org with esmtp (Exim 4.34 (FreeBSD))
	id 1BVVyQ-000HtR-UO; Wed, 02 Jun 2004 15:40:08 +0200
Message-ID: <40BDD8B6.80103@fillmore-labs.com>
Date: Wed, 02 Jun 2004 15:40:06 +0200
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/
MIME-Version: 1.0
To: Kris Kennaway <kris@obsecurity.org>
References: <20040602121648.GA51625@xor.obsecurity.org>
	<40BDCC4B.9000708@fillmore-labs.com>
	<20040602132149.GA55452@xor.obsecurity.org>
In-Reply-To: <20040602132149.GA55452@xor.obsecurity.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: KMail/1.5.9
cc: ports@FreeBSD.org
Subject: Re: INDEX patch
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jun 2004 13:40:10 -0000

Kris Kennaway wrote:

> On Wed, Jun 02, 2004 at 02:47:07PM +0200, Oliver Eikemeier wrote:
> 
>>Kris Kennaway wrote:
>>
>>
>>>A previous commit to bsd.port.mk broke the reporting of missing
>>>dependencies from 'make index'.  This patch restores it (and makes
>>>these errors fatal).  I plan to commit it soon.
>>>
>>>Kris
>>
>>May I suggest the following patch:
>>
>>- check for existence of perl (cf. my RFC on ports-developers)
>>- enables the use of `env PATH= /usr/bin/make describe' (nice for testing)
> 
> Nice idea, but running this test 11000 times is suboptimal :-)

Because test is a sh-builtin, and the file system should cache this information
I don't expect to see any difference. Especially since spawning perl 11000 times
is more than suboptimal ;) You didn't mean this serious, did you?

> Also, it recommends the wrong perl port.

Just replace it with "lang/${PERL_PORT}".

-Oliver