From owner-freebsd-hackers@FreeBSD.ORG Sun Jul 31 16:56:52 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71665106566B; Sun, 31 Jul 2011 16:56:52 +0000 (UTC) (envelope-from rmh.aybabtu@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 234098FC13; Sun, 31 Jul 2011 16:56:51 +0000 (UTC) Received: by iyb11 with SMTP id 11so7905178iyb.13 for ; Sun, 31 Jul 2011 09:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=NWO80SjmZZSPIMROas6yBi33M2SMIO+WpA8pVnjUfnU=; b=S8Uw0ZcxMpdDKqS7om3O2sXVJ1850yCCwh3lmdG1rgyZc5cypZ2fB21c4qHQjxG+nS 24qfieyAofaQWywtRr+znErCoZ3voaqEVYuaQirjmBS/RUucpYc6Twvy0YhqjaFBaL+A 7D7GXtbuAvUr0tF7qMQbvsXxQnnlft2oudevs= MIME-Version: 1.0 Received: by 10.43.134.8 with SMTP id ia8mr2619458icc.113.1312131411463; Sun, 31 Jul 2011 09:56:51 -0700 (PDT) Sender: rmh.aybabtu@gmail.com Received: by 10.42.243.129 with HTTP; Sun, 31 Jul 2011 09:56:51 -0700 (PDT) In-Reply-To: <20110730173239.GA17489@deviant.kiev.zoral.com.ua> References: <20110730173239.GA17489@deviant.kiev.zoral.com.ua> Date: Sun, 31 Jul 2011 18:56:51 +0200 X-Google-Sender-Auth: 5oFJhEx2NZuct0Wc6nq60MU-O_o Message-ID: From: Robert Millan To: Kostik Belousov Content-Type: text/plain; charset=UTF-8 Cc: freebsd-hackers@freebsd.org, freebsd-emulation@freebsd.org, Ed Maste Subject: Re: kern/159281: [PATCH] Linux-like /proc/swaps for linprocfs X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2011 16:56:52 -0000 2011/7/30 Kostik Belousov : > Second, my proposal contains a flaw. Namely, if some swap device was removed > between calls to swap_info and swap_devname calls, we get mangled list. Ok, I see that you fixed this by unifying those functions. > The third problem, which is not fixed, and which I do not want to handle, > is that the swap devices list can be changed between calls to swap_devname(), > changing device indexes and thus making the output mangled. You say you don't want to handle this, but AFAICT from the patch you already did. Or did I miss something? > Should the swap device name be separated from 'unknown' word by > space or by tab ? Linux' /proc/swaps prints spaces after the first column and tabs for the rest. I think it's better to do the same just in case, but I don't think it's relevant either way. > I updated your patch, hopefully fixing the issues. Do you have comments > or objections ? No. Thanks for fixing those problems. -- Robert Millan