From owner-cvs-src@FreeBSD.ORG Tue Feb 8 03:43:03 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A5E716A4CE; Tue, 8 Feb 2005 03:43:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1FA6443D1F; Tue, 8 Feb 2005 03:43:03 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j183h2Ux041955; Tue, 8 Feb 2005 03:43:02 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j183h2Nt041950; Tue, 8 Feb 2005 03:43:02 GMT (envelope-from scottl) Message-Id: <200502080343.j183h2Nt041950@repoman.freebsd.org> From: Scott Long Date: Tue, 8 Feb 2005 03:43:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/twe twe.c twe_freebsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2005 03:43:03 -0000 scottl 2005-02-08 03:43:02 UTC FreeBSD src repository Modified files: sys/dev/twe twe.c twe_freebsd.c Log: Fix crashdumps on twe. The twe_immediate_request() path was not only copying data to a temporary buffer before the I/O, but also copying that temporary buffer back to the original data location after the I/O. When you're dumping kernel heap and stack and protected pages, this is very very bad. A belated thanks to Robert Watson for donating hardware for this (and future) work. MFC after: 3 days Revision Changes Path 1.24 +24 -9 src/sys/dev/twe/twe.c 1.40 +1 -3 src/sys/dev/twe/twe_freebsd.c