From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Feb 14 10:20:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E51939AD for ; Thu, 14 Feb 2013 10:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id C911D280 for ; Thu, 14 Feb 2013 10:20:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r1EAK1rI096942 for ; Thu, 14 Feb 2013 10:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r1EAK1Vi096941; Thu, 14 Feb 2013 10:20:01 GMT (envelope-from gnats) Resent-Date: Thu, 14 Feb 2013 10:20:01 GMT Resent-Message-Id: <201302141020.r1EAK1Vi096941@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jarrod Sayers Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 1762E8BB for ; Thu, 14 Feb 2013 10:11:47 +0000 (UTC) (envelope-from jarrod@downtools.com.au) Received: from mail.downtools.com.au (mail.downtools.com.au [123.136.33.243]) by mx1.freebsd.org (Postfix) with ESMTP id 90D9D225 for ; Thu, 14 Feb 2013 10:11:46 +0000 (UTC) Received: from mail.downtools.com.au (mail.downtools.com.au [123.136.33.243]) by mail.downtools.com.au (8.14.4/8.14.4) with ESMTP id r1EA7btB093924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Feb 2013 20:37:37 +1030 (CST) (envelope-from jarrod@downtools.com.au) Received: (from jarrod@localhost) by mail.downtools.com.au (8.14.4/8.14.4/Submit) id r1EA7Z2o093923; Thu, 14 Feb 2013 20:37:35 +1030 (CST) (envelope-from jarrod) Message-Id: <201302141007.r1EA7Z2o093923@mail.downtools.com.au> Date: Thu, 14 Feb 2013 20:37:35 +1030 (CST) From: Jarrod Sayers To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/176140: [patch] comms/minicom: Correct Previous NOPORTDOCS Logic X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Jarrod Sayers List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2013 10:20:02 -0000 >Number: 176140 >Category: ports >Synopsis: [patch] comms/minicom: Correct Previous NOPORTDOCS Logic >Confidential: no >Severity: non-critical >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Feb 14 10:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Jarrod Sayers >Release: FreeBSD 9.0-RELEASE-p5 i386 >Organization: >Environment: System: FreeBSD mail.downtools.com.au 9.0-RELEASE-p5 FreeBSD 9.0-RELEASE-p5 #23: Sat Dec 15 08:56:43 CST 2012 root@burbank.downtools.com.au:/usr/obj/usr/src/sys/BURBANK i386 >Description: The recent commit to comms/minicom r311786 appears to have slightly incorrect logic around the change from NOPORTDOCS to PORT_OPTIONS:MDOCS. If true, the former prevents port documentation from being installed however the latter allows the documentation to be installed. The condition on line 63 was not changed resulting in the evaluation being the inverse, i.e. port documentation being installed when explicitly told not to, and not being installed when told to. Attach patch drops the wayward ! symbol. >How-To-Repeat: >Fix: Patch can also be downloaded from: http://www.downtools.com.au/~jarrod/FreeBSD/comms-minicom-PORT_OPTIONS.diff --- comms-minicom-PORT_OPTIONS.diff begins here --- diff -ruN ports/comms/minicom.orig/Makefile ports/comms/minicom/Makefile --- ports/comms/minicom.orig/Makefile 2013-02-07 09:05:10.000000000 +1030 +++ ports/comms/minicom/Makefile 2013-02-14 20:05:58.000000000 +1030 @@ -60,7 +60,7 @@ ${CHMOD} 4511 ${PREFIX}/bin/minicom ${INSTALL} -d -o root -g wheel -m 0755 ${PREFIX}/etc/minicom ${CHOWN} uucp ${PREFIX}/etc/minicom -.if !${PORT_OPTIONS:MDOCS} +.if ${PORT_OPTIONS:MDOCS} ${INSTALL} -d -o root -g wheel -m 0755 ${DOCSDIR} ${INSTALL_DATA} ${WRKSRC}/AUTHORS ${DOCSDIR}/ ${INSTALL_DATA} ${WRKSRC}/COPYING ${DOCSDIR}/ --- comms-minicom-PORT_OPTIONS.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: