Date: Wed, 13 Dec 2023 06:32:44 -0500 From: Adam Weinberger <adamw@adamw.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Larry Rosenman <ler@freebsd.org>, Ashish SHUKLA <ashish@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8d096cbc7af5 - main - sysutils/lsof: add a build depends on bash for the timebeing. Message-ID: <CAP7rwcieVLpb9Z4ENHBxkRb88XkToj7TWZccKhPq=q-L_JWyyw@mail.gmail.com> In-Reply-To: <526e9cf0-55cf-afac-b8b5-5005e63cc6ae@pfeifer.com> References: <202312050108.3B518qwD065426@gitrepo.freebsd.org> <653e5bc3811b06d371517936f02cf0c2@FreeBSD.org> <1e93ed1a910819a38a332a580b4746d0@FreeBSD.org> <526e9cf0-55cf-afac-b8b5-5005e63cc6ae@pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000888ef6060c628745 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 13, 2023 at 12:26=E2=80=AFAM Gerald Pfeifer <gerald@pfeifer.com= > wrote: > On Mon, 4 Dec 2023, Larry Rosenman wrote: > >>> +BUILD_DEPENDS=3D /usr/local/bin/bash:shells/bash > >> s,/usr/local,${LOCALBASE}, > > I'm out of practice :( > > No worries, just note we have tools to support us. > > I gave this a try and got the following from portlint: > > % portlint -C > WARN: Makefile: possible use of absolute pathname > "/usr/local/bin/bash:...". > Also just FTR, BUILD/RUN_DEPENDS works without absolute pathnames. This would work fine too (and is the more common invocation): BUILD_DEPENDS=3D bash:shells/bash # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org --000000000000888ef6060c628745 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:arial,sans-serif">On Wed, Dec 13, 2023 at 12:26=E2=80=AFAM Gerald = Pfeifer <<a href=3D"mailto:gerald@pfeifer.com">gerald@pfeifer.com</a>>= ; wrote:</div></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_q= uote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,2= 04);padding-left:1ex">On Mon, 4 Dec 2023, Larry Rosenman wrote:<br> >>> +BUILD_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0/usr/local/bin/bash:shells/bash<br> >> s,/usr/local,${LOCALBASE},<br> > I'm out of practice :(<br> <br> No worries, just note we have tools to support us.<br> <br> I gave this a try and got the following from portlint:<br> <br> =C2=A0 % portlint -C<br> =C2=A0 WARN: Makefile: possible use of absolute pathname "/usr/local/b= in/bash:...".<br clear=3D"all"></blockquote><div><br></div><div style= =3D"font-family:arial,sans-serif" class=3D"gmail_default">Also just FTR, BU= ILD/RUN_DEPENDS works without absolute pathnames. This would work fine too = (and is the more common invocation):</div><div style=3D"font-family:arial,s= ans-serif" class=3D"gmail_default">BUILD_DEPENDS=3D=C2=A0 bash:shells/bash<= /div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_default"><b= r></div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_default"= ># Adam</div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_def= ault"><br></div></div><br><span class=3D"gmail_signature_prefix">-- </span>= <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div><div d= ir=3D"ltr"><div>Adam Weinberger</div><div><a href=3D"mailto:adamw@adamw.org= " target=3D"_blank">adamw@adamw.org</a></div><div><a href=3D"https://www.ad= amw.org" target=3D"_blank">https://www.adamw.org</a></div></div></div></div= ></div></div> --000000000000888ef6060c628745--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcieVLpb9Z4ENHBxkRb88XkToj7TWZccKhPq=q-L_JWyyw>