From owner-svn-src-all@freebsd.org Thu Mar 9 15:45:15 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0F0A5D05628 for ; Thu, 9 Mar 2017 15:45:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CB95DD71 for ; Thu, 9 Mar 2017 15:45:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22a.google.com with SMTP id f84so29575561ioj.0 for ; Thu, 09 Mar 2017 07:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=W2XjiLJyLrRHwmo3Z8M7oZ2rHw3FNnn7UAXgRuj+26c=; b=YIhUi0QwaUAM3Z8TgCtPo/ErQD/hQTtn+XWUmfTeEK7+xMs9L3uB9USQ60BMIsJrCo fi78sSyzMMCXdwoxLQ3caVf14ETNGjja243bMpPTtbLNm6v7G9pqLEnWDjz02cSMSUDr Lpay7unOwGXBE/xmEjNUWnSiOGGYos69sEWOPlwSctCXrJFX0mnmWxSAUOFTLCEQ3RnO Yvf/TQ5rPodS3OvHwqvEUp+kqHq90Zpg9Y0E4ZxsVTLX1haqCJJRPpf1zPYQmnGwwcfy rgZQvvCKlEXfOUgM+4eo+jqq9otGQOdIw3Ll3AcTvFhmSdyUtKPGjgmuMVAnuxK5BTn6 TREA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=W2XjiLJyLrRHwmo3Z8M7oZ2rHw3FNnn7UAXgRuj+26c=; b=T7aHjuKxFhhJ5acfMCapxUeHjz9s6keuRHHGE4T/3QDT85P+AcjOAjLCvrx/Ucz0pL o1QWmkqsyM+d+jW5BCD0v4zR/PzBwGUtWfp80/XpJ1JDdbiFxQLFnBbgDoCvcY2kx+Iy NARfcWr1R67moV3b+boTaVKYecS0p7pgRKYpNqt1BSBsgRVog4kKRmNZvrBykObG8+qY eQsOmOreQ09qiELOLkTb7iU2CVOo0Qs0l5v5UigbDAFFbKmiMTd22Nk/gYBbJhTkDiuQ 2LJ/uky22lPebVSjQUzUxU++CGGnNPokskQHHUO/FU4VKXbXiuHI+OySJMF5EaURJmiH z0DQ== X-Gm-Message-State: AMke39nLOm8DwhoXOzWXi07ciQX9wlE4/QJpn4anloNEcF5HcHge2IM0eclqaRGB9s9gHLm6RNO7Had8jh3Wdw== X-Received: by 10.107.134.94 with SMTP id i91mr11735354iod.0.1489074313964; Thu, 09 Mar 2017 07:45:13 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.129 with HTTP; Thu, 9 Mar 2017 07:45:13 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <6108f2d1-9c13-66e2-7500-7eb035c0a98f@FreeBSD.org> References: <201703091526.v29FQmRG007171@pdx.rh.CN85.dnsmgr.net> <6108f2d1-9c13-66e2-7500-7eb035c0a98f@FreeBSD.org> From: Warner Losh Date: Thu, 9 Mar 2017 08:45:13 -0700 X-Google-Sender-Auth: DsJOem2Y7-C_whELsCOiH34nZhw Message-ID: Subject: Re: svn commit: r314961 - head/usr.bin/localedef To: Pedro Giffuni Cc: rgrimes@freebsd.org, src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 15:45:15 -0000 On Thu, Mar 9, 2017 at 8:37 AM, Pedro Giffuni wrote: > > On 3/9/2017 10:26 AM, Rodney W. Grimes wrote: >>> >>> Author: pfg >>> Date: Thu Mar 9 15:21:03 2017 >>> New Revision: 314961 >>> URL: https://svnweb.freebsd.org/changeset/base/314961 >>> >>> Log: >>> localedef(1): Fix for memory leaks reported by coverity. >>> Also some small cleanups to match better current illumos. >>> CID: 1338540, 1338541, 1338557, 1338566 >>> Obtained from: illumos >>> Discussed with: Yuri Pankov (@Nexenta) >>> MFC after: 5 days >>> >>> Modified: >>> head/usr.bin/localedef/collate.c >>> head/usr.bin/localedef/ctype.c >>> head/usr.bin/localedef/localedef.c >>> head/usr.bin/localedef/localedef.h >>> head/usr.bin/localedef/time.c >>> >>> Modified: head/usr.bin/localedef/collate.c >>> >>> ============================================================================== >>> --- head/usr.bin/localedef/collate.c Thu Mar 9 13:41:57 2017 >>> (r314960) >>> +++ head/usr.bin/localedef/collate.c Thu Mar 9 15:21:03 2017 >>> (r314961) >>> @@ -1,5 +1,5 @@ >>> /* >>> - * Copyright 2010 Nexenta Systems, Inc. All rights reserved. >>> + * Copyright 2017 Nexenta Systems, Inc. >> >> Now this is defanitly a wrong thing to do with a copyright notice, >> always error on the side of OLDEST date, never newest. You have now >> extended Nexenta's claim to 2010 work by 7 years. >> > Which is fine. > Nexenta was so really nice to relicense this from CDDL to BSD, just for us. That was nice of Nexenta. We shouldn't harp on them in return for conducting their business in a way that's different from how we'd conduct ours. The copyright belongs to them. It's their duty to report and mark their works in accordance to their best interests, including complying with bits of the law. We should let them do it because it is none of our concern. We should not repay their kindness with needless whining. Warner