From owner-freebsd-current Mon Jun 17 20:25: 0 2002 Delivered-To: freebsd-current@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 5195937B40F for ; Mon, 17 Jun 2002 20:24:56 -0700 (PDT) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.3/8.12.2) with ESMTP id g5I3LsP8020670; Mon, 17 Jun 2002 20:21:54 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.4/8.12.3/Submit) id g5I3Lscq020669; Mon, 17 Jun 2002 20:21:54 -0700 (PDT) Date: Mon, 17 Jun 2002 20:21:54 -0700 From: "David O'Brien" To: Garrett Wollman Cc: Thomas David Rivers , mb@imp.ch, current@FreeBSD.ORG Subject: Re: PATCH: wchar_t is already defined in libstd++ Message-ID: <20020617202154.B20621@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG Mail-Followup-To: David O'Brien , Garrett Wollman , Thomas David Rivers , mb@imp.ch, current@FreeBSD.ORG References: <20020617235725.F60170-100000@levais.imp.ch> <200206172202.g5HM2HW52939@lakes.dignus.com> <200206172216.g5HMGjrS022873@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200206172216.g5HMGjrS022873@khavrinen.lcs.mit.edu>; from wollman@lcs.mit.edu on Mon, Jun 17, 2002 at 06:16:45PM -0400 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Jun 17, 2002 at 06:16:45PM -0400, Garrett Wollman wrote: > < said: > > > The correct approach (and, I have to admit to not > > glancing at your patch) would be: > > > #ifndef __cplusplus > > typedef _BSD_WCHAR_T_ wchar_t > > #endif > > Actually, the correct approach would be to avoid defining > _BSD_WCHAR_T_ when compiling C++. This way, it only needs to be done I am much more likely to force the libstdc++ build to use our _BSD_WCHAR_T_. Our types should be centralized and not in some hidden vendor software that often makes wrong assumptions about us. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message