From nobody Sat Sep 20 00:47:39 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cT9hC6R7Kz67vTY; Sat, 20 Sep 2025 00:47:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cT9hC4LYCz40Wh; Sat, 20 Sep 2025 00:47:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758329259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AeapaHlfL9QnjMjGt64u638dp9gcQxL6aHv2gUhwrvI=; b=YEAJdDA5b7Ym1U9/ygfiLVbC5XKgOCrUEZN448KjI+w9U+mUjct/rdRI8S3jL/I3eCODrz 7LRVUQ0xL5lfcamxK9Fy1+iu9Kpcp11HjcbykEGx2n13A46Z9UoPRL6Zx58RLTixRNd4IY 1aORlRcFrdoTvQgxVNEVCN5LPgOML5VLUeABnWaCg8XsK37J9HC1DfjAEwTYj2V3ANajk6 7SoKX3CxqxfvwDL43dracrvxb1JBTHsIzOu3JA3RlEGzAbar0dW+klrjQIYpjgOdw5RphG SQen1w5+EmWwjmsDlbzF1jJ/JVevXCwenxD5n4asgr3h9ZXZ39BL6JqfxcAAeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758329259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AeapaHlfL9QnjMjGt64u638dp9gcQxL6aHv2gUhwrvI=; b=aJrU9GP/UmB6KKzJyS8zH7vVEUrkJjM6cxQy3nRzotFycukaUGLYAVsxTM85mr2WL4jqlN l48QqLjOC50G0UsFr234EzvHUbKIA+cTckCj6I4/8VOtKrFc4mzGiACSoO/CKarpPl6MLn x626iJwAJAwks7Jtw7OJwmb/75aelBKfZdNuiJrntt0VxUlHAhcr740/oiUl99hmzCq9tC e54BnVuDhTBiooFb/JfXgAFFHiFYz3PvVVDqA5L5Dbz4QqRGno3vlKuJC6nKXUGXmdyXzB 2yCvfvTNO/7WcmWZ56BFuVXaxVrjEuQJEHL6bYIyJXxaNRLAn5BRUOwGnSPcsQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758329259; a=rsa-sha256; cv=none; b=SdsKTbSOJxRh5G68cAk7CmLO3JRebf61e/MYi/TRAb/eD0GIq4BaldncB/AI858+3lVZS+ WIRIIOQG+0nQ0Ss0+TH3Y4JdFDuh53SGiwQnmE4mvjjvWcePlf4xjide7+Rtgm03g9CCgs F2B5NeNVw93pdsuG5x/0ZGvFBePRy4KzFRRmG9aCBJnWdAiOhGXPxJzLMH9cyGm5ww4uQl h1xbfXYXO6C1uKIEppIGd54vVa47vejXLNwqsgZY9wi65gKGClgypayQXxKp/gSIGVzgMF XWGXbT3n4utKJXCb0PMW7H9XJJ5dDHcXUt1OF36iSqkUiLDjbnGbDRnCvQowNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cT9hC3yMNz1KQQ; Sat, 20 Sep 2025 00:47:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58K0ldWl017073; Sat, 20 Sep 2025 00:47:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58K0ldcL017070; Sat, 20 Sep 2025 00:47:39 GMT (envelope-from git) Date: Sat, 20 Sep 2025 00:47:39 GMT Message-Id: <202509200047.58K0ldcL017070@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: d9ae618c0816 - main - [rtwn] don't send NULL data frames if we're compiled with firmware enabled List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d9ae618c0816d24bc8127e479db5787c97a23140 Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=d9ae618c0816d24bc8127e479db5787c97a23140 commit d9ae618c0816d24bc8127e479db5787c97a23140 Author: Adrian Chadd AuthorDate: 2025-08-27 17:04:39 +0000 Commit: Adrian Chadd CommitDate: 2025-09-20 00:44:19 +0000 [rtwn] don't send NULL data frames if we're compiled with firmware enabled the firmware should be sending these. Differential Revision: https://reviews.freebsd.org/D52298 Reviewed by: bz Locally tested: * rtl8821/rtl8812au (STA) --- sys/dev/rtwn/if_rtwn.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/rtwn/if_rtwn.c b/sys/dev/rtwn/if_rtwn.c index 25287f222270..c5889937fb08 100644 --- a/sys/dev/rtwn/if_rtwn.c +++ b/sys/dev/rtwn/if_rtwn.c @@ -271,6 +271,11 @@ rtwn_attach(struct rtwn_softc *sc) /* Enable seqno offload */ ic->ic_flags_ext |= IEEE80211_FEXT_SEQNO_OFFLOAD; +#ifdef RTWN_WITHOUT_UCODE + /* Don't originate NULL data frames - let firmware do this */ + ic->ic_flags_ext |= IEEE80211_FEXT_NO_NULLDATA; +#endif + /* Adjust capabilities. */ rtwn_adj_devcaps(sc);