From owner-freebsd-bugs  Sun Jun 28 19:40:53 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id TAA20474
          for freebsd-bugs-outgoing; Sun, 28 Jun 1998 19:40:53 -0700 (PDT)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA20460
          for <freebsd-bugs@FreeBSD.org>; Sun, 28 Jun 1998 19:40:47 -0700 (PDT)
          (envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.8.8/8.8.5) id TAA17024;
	Sun, 28 Jun 1998 19:40:01 -0700 (PDT)
Received: from fledge.watson.org (robert@COPLAND.CODA.CS.CMU.EDU [128.2.222.48])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA20438
          for <FreeBSD-gnats-submit@freebsd.org>; Sun, 28 Jun 1998 19:40:22 -0700 (PDT)
          (envelope-from robert@fledge.watson.org)
Received: (from robert@localhost)
	by fledge.watson.org (8.8.8/8.8.8) id WAA06756;
	Sun, 28 Jun 1998 22:40:18 -0400 (EDT)
Message-Id: <199806290240.WAA06756@fledge.watson.org>
Date: Sun, 28 Jun 1998 22:40:18 -0400 (EDT)
From: robert@cyrus.watson.org
Reply-To: robert+freebsd@cyrus.watson.org
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: kern/7105: current: src/sys/libkern/qsort.c includes stdio.h
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         7105
>Category:       kern
>Synopsis:       libkern source includes stdio.h (inappropriate include)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 28 19:40:00 PDT 1998
>Last-Modified:
>Originator:     Robert Watson
>Organization:
>Release:        FreeBSD 3.0-CURRENT i386
>Environment:
IBM notebook

	

>Description:

qsort.c includes stdio.h.  This seems inappropriate as it doesn't
(apparently) use anything from it.  Also, shouldn't it be including
sys/libkern.h if it needs access to things like printf?

>How-To-Repeat:

n/a

Discovered the problem when a source tree was out of sync with the 
/usr/include tree.  As a result, one of the typedefs failed in something
included from stdio.  Leading me to question why it was included.

>Fix:
	
Delete the line #include <stdio.h>

>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message