From owner-svn-ports-all@freebsd.org Sat Mar 26 22:22:11 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D47BADE684 for ; Sat, 26 Mar 2016 22:22:11 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: from vfemail.net (onethreetwo.vfemail.net [199.16.11.132]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A18411241 for ; Sat, 26 Mar 2016 22:22:10 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: (qmail 85043 invoked by uid 89); 26 Mar 2016 22:22:09 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 26 Mar 2016 22:22:09 -0000 Received: (qmail 84903 invoked by uid 89); 26 Mar 2016 22:21:51 -0000 Received: by simscan 1.3.1 ppid: 84895, pid: 84899, t: 0.0038s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 26 Mar 2016 22:21:51 -0000 Received: (qmail 6455 invoked by uid 89); 26 Mar 2016 22:21:51 -0000 Received: by simscan 1.4.0 ppid: 6427, pid: 6438, t: 0.8501s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by mail.vfemail.net with ESMTPA; 26 Mar 2016 22:21:50 -0000 From: Jan Beich To: Kurt Jaeger Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r411957 - in head/multimedia: . syncplay syncplay/files References: <201603261851.u2QIpL6M096985@repo.freebsd.org> <8u14-51v5-wny@vfemail.net> Date: Sat, 26 Mar 2016 23:21:42 +0100 In-Reply-To: <8u14-51v5-wny@vfemail.net> (Jan Beich's message of "Sat, 26 Mar 2016 23:08:14 +0100") Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2016 22:22:11 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Jan Beich writes: > Kurt Jaeger writes: > >> +.if !empty(PORT_OPTIONS:MCLIENT) && !empty(PORT_OPTIONS:MSERVER) >> +INSTALL_TARGET=3D install >> +.endif >> + >> +.include > > PORT_OPTIONS is always empty before is included > which this port doesn't attempt. If you want to keep .if conditionals > out try the untested patch below. > > Index: multimedia/syncplay/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- multimedia/syncplay/Makefile (revision 411966) > +++ multimedia/syncplay/Makefile (working copy) > @@ -26,6 +26,7 @@ OPTIONS_MULTI_MODES=3D CLIENT SERVER > VLC_DESC=3D Support for VLC media player >=20=20 > MAKEFILE=3D GNUmakefile > +INSTALL_TARGET=3D # empty Actually, the way INSTALL_TARGET is defined via ?=3D in bsd.port.mk this line is not even needed. OPTIONS_MULTI guarantees either CLIENT or SERVER overrides default value. >=20=20 > GUI_RUN_DEPENDS=3D pyside-py2?>=3D1.1.2:devel/pyside >=20=20 > @@ -34,8 +35,4 @@ VLC_MAKE_ARGS_OFF=3D VLC_SUPPORT=3Dfalse > CLIENT_INSTALL_TARGET=3D install-client > SERVER_INSTALL_TARGET=3D install-server >=20=20 > -.if !empty(PORT_OPTIONS:MCLIENT) && !empty(PORT_OPTIONS:MSERVER) > -INSTALL_TARGET=3D install > -.endif > - > .include --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJW9wt2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b274IAJ977xjmTdFE/dY+gEXoKkSB 2HNy3eYgj4PXO5BmU5WMhy9nQMEni70mqhwfw21YQ/CRiryJbxO1IodtBFG0KuuP diGaQEoHy0MklylreHGuEFXODlyk9VU3aQbDLuSOWggcOEHNmNZ0u7uSzLV3XqN1 +RY3K4INEqW2BKIqjxaOeNA0syB06GJaiX8gJvanLSGMbBmoU5cZD2xXfDMJ55f0 aHP9ZBh4TOUgSXMH7rctt8XxR88EzIixfdKDL9Z+Ck3FiXtTQmj7nKkKvVsDUATb tEeaAj6FBBPYvFcHFG4+v7eLlvFVs8S7tvtNOITq/+M3Ytov/1J/1NrVeeGgWjE= =KWzS -----END PGP SIGNATURE----- --=-=-=--