From owner-cvs-src@FreeBSD.ORG Tue Sep 19 19:54:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C9D6616A407 for ; Tue, 19 Sep 2006 19:54:26 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 25E5443D55 for ; Tue, 19 Sep 2006 19:54:24 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 16064 invoked from network); 19 Sep 2006 19:57:28 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Sep 2006 19:57:28 -0000 Message-ID: <45104AEF.10000@freebsd.org> Date: Tue, 19 Sep 2006 21:54:23 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Jung-uk Kim References: <200609182218.k8IMIMUT059300@repoman.freebsd.org> <200609191431.01649.jkim@FreeBSD.org> <20060919190449.GC720@turion.vk2pj.dyndns.org> <200609191535.08184.jkim@FreeBSD.org> In-Reply-To: <200609191535.08184.jkim@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Peter Jeremy , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, John Baldwin , cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2006 19:54:26 -0000 Jung-uk Kim wrote: > On Tuesday 19 September 2006 03:04 pm, Peter Jeremy wrote: >> On Tue, 2006-Sep-19 14:30:59 -0400, Jung-uk Kim wrote: >>> On Tuesday 19 September 2006 01:52 pm, John Baldwin wrote: >>>> Which I'm about to kill hopefully. Please let's fix this the >>>> right way and not hack it any further. >>> Sure, no problem. But I don't think we can DTRT on -STABLE >>> without breaking API. Can we? >> I've had a quick look into this problem because I extensively use >> VLANs on a bge and discovered that I no longer have VLAN tag >> details (which makes packet tracing a nuisance). >> >> As far as I can see, there is nothing preventing bpf_tap() and >> bpf_mtap2() being doctored to undo the VLAN detagging so that >> bpf_filter() is passed a mbuf chain that looks like an 802.1Q >> ethernet frame: Dummy up an mbuf (as bpf_mtap2() does) that >> contains the MAC addresses from the incoming data followed by >> the 802.1Q packet type and tag information, with m_next pointing >> to the byte after the MAC addresses in the original data. > > Why don't we just fake it up from ether_input() and pass it to > BPF_MTAP() instead of 'teaching' bpf? I think it is more logical > thing to do. Then it would be kinda pointless to have the hardware remove it in the first place. -- Andre