Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Nov 2019 15:22:32 +0100
From:      Mateusz Piotrowski <0mp@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r517323 - in head/www: . httpdirfs httpdirfs/files
Message-ID:  <7385a083-3b35-b3c7-827a-4587be492019@FreeBSD.org>
In-Reply-To: <20191112112440.GA34193@FreeBSD.org>
References:  <201911121054.xACAsxDE031564@repo.freebsd.org> <20191112112440.GA34193@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,

On 11/12/19 12:24 PM, Alexey Dokuchaev wrote:
> On Tue, Nov 12, 2019 at 10:54:59AM +0000, Mateusz Piotrowski wrote:
>> New Revision: 517323
>> URL: https://svnweb.freebsd.org/changeset/ports/517323
>>
>> Log:
>>    New port: www/httpdirfs: FUSE filesystem to mount HTTP directory
>>    listings, with a permanent cache
> It would be nice if you'd taken a look at other fuse-* ports first.
>
>> Added: head/www/httpdirfs/Makefile
>> ==============================================================================
>> @@ -0,0 +1,40 @@
>> +# $FreeBSD$
>> +
>> +PORTNAME=	httpdirfs
>> +DISTVERSION=	1.2.0
>> +CATEGORIES=	www
> I'd say that `net' or `sysutils' would be better category for this type
> of software.
>
> Missing PKGNAMEPREFIX=fusefs- (also in the port directory name).
>
>> +LIB_DEPENDS=	libcurl.so:ftp/curl \
>> +		libexpat.so:textproc/expat2 \
>> +		libfuse.so:sysutils/fusefs-libs \
> USES+=fuse.
>
>> Added: head/www/httpdirfs/pkg-descr
>> @@ -0,0 +1,16 @@
>> +Have you ever wanted to mount those HTTP directory listings as if it was a
>> +partition? Look no further, this is your solution. HTTPDirFS stands for Hyper
>> +Text Transfer Protocol Directory Filesystem.
>> +
>> +The performance of the program is excellent.
> We typically discourage "talking to user" style in the port description,
> as well as judgmental assessments ("performance is excellent") coming from
> the software author(s).
>
> ./danfe


You are absolutely right. Thank you for reviewing the commit. I've 
committed an update to address your comments in 518239.

Regards,

Mateusz




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7385a083-3b35-b3c7-827a-4587be492019>