From nobody Fri Oct 13 23:53:54 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S6jyV4Ccwz4wyK0; Fri, 13 Oct 2023 23:53:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S6jyV3jsPz3KG0; Fri, 13 Oct 2023 23:53:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697241234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8v+vBvD5Ke8p52N2FklLm4HTNKRsZWwOxtbQ6ysEQE0=; b=VaQG/CEOI2cCQP+fTwkcsoEb6aT6eUjX5dmfHoII2gGROgi9vBC4AanCa/ucPSOGkPJERo hZJIFaB1Udy8ZrdI4n5lMOjZEi8hPvH3fwozWpP1pdOIg4tqM57DYXvhXa3ykb8M7Eb1H4 yqh2On93h2DtIKetV4aiSLWR2fniJtid3ifxqIcLfOaqiA83KRkdQy7dnXMLdQRLj0f5OH 71udbGwELSEKP96kJeTFCssWnwq2sHWTt5DT6qSr/0/dUok1kFskA+QLAjNPhoWbG20IJF opK0ADmysoejuefuie8jfzzxhxQhQVNOwjEkS9MRnShejLY5DM4qM34Q7SSKAw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697241234; a=rsa-sha256; cv=none; b=wpd5DtJTQUEkz702JhDcndUC3XPGkBQxP/TSI+oc0lQdP7wmDCImJ/OsjZKVJXhaVHEHqh pytY4pWCTUVpB52TkZEid3psbLcGEHmGG1ZQ2HwhOGkgBI8vbxrf58u6YL9uvgWrRfTXNn MBpPRxJCjsSofCzLJXvhPIJIxX568sTiNKC6BOcllha+oZWwCOcMW3E1NlamI3SjNR8LVL DkvlF9bPKlIFWXSDRvA3TKHSkmxjkMPpj17JL2/Vrm20Zg7LxyHPVIpcntGGmtz+E64jDX lEO/F8QnwSICzC+EUZzU/VpT0xTklupm8mvsDQl7uxHKg6oIRgNKqVS1spBkZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697241234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8v+vBvD5Ke8p52N2FklLm4HTNKRsZWwOxtbQ6ysEQE0=; b=Y5GiYc12t4bsMHzo/xP4rNQKCCTyF2b2e35i/AcSebbXhefCL+OhCAzxH5PHGKUbM4z+Si nPT/PHIfmDqfPQe6HOouKlYkrceDlWkW2qHl/lq8vhH/ezzg0FB0ypmcmrdGXWQJBs2SWN whdhz1PAP7BzvNiGGVkR6/Si0QdxcS8C1LaeIpoPwozI2EjiN3pp0Lbio/pnFqslCytc+x yFQQzqGVfiAndYsKJCx0MeKHFvCKSrs/eoebML4tSbuPQsUTRsHb/XZTLk2JQFzfrDV4p2 8i8D0GIIT0EB26ArWw59DE/GLnUj8S7B0UuDX7sASVVU0SYJjOx9aeH3o5PrHw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S6jyV2d5Cz17Vr; Fri, 13 Oct 2023 23:53:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39DNrsNF032217; Fri, 13 Oct 2023 23:53:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39DNrsoC032214; Fri, 13 Oct 2023 23:53:54 GMT (envelope-from git) Date: Fri, 13 Oct 2023 23:53:54 GMT Message-Id: <202310132353.39DNrsoC032214@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 7ec19caae5b0 - stable/13 - vfs: consult freevnodes in vnlru_kick_cond List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 7ec19caae5b0044da963298d4ae79cfcf3ebaf01 Auto-Submitted: auto-generated The branch stable/13 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=7ec19caae5b0044da963298d4ae79cfcf3ebaf01 commit 7ec19caae5b0044da963298d4ae79cfcf3ebaf01 Author: Mateusz Guzik AuthorDate: 2023-10-10 16:19:53 +0000 Commit: Mateusz Guzik CommitDate: 2023-10-13 23:48:13 +0000 vfs: consult freevnodes in vnlru_kick_cond If the count is high enough there is no point trying to produce more. Not going there reduces traffic on the vnode_list mtx. This further shaves total real time in a test mentioned in: 74be676d87745eb7 ("vfs: drop one vnode list lock trip during vnlru free recycle") -- 20 instances of find each creating 1 million vnodes, while total limit is set to 400k. Time goes down from ~41 to ~35 seconds. Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 23ef25d25d989e7213bc1d3ef32b0f48a9eb2537) --- sys/kern/vfs_subr.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 29b255b418e4..5ddbff77a221 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -1601,6 +1601,9 @@ static void vnlru_kick_cond(void) { + if (vnlru_read_freevnodes() > wantfreevnodes) + return; + if (vnlruproc_sig) return; mtx_lock(&vnode_list_mtx); @@ -1867,9 +1870,8 @@ vn_alloc_hard(struct mount *mp) } alloc: mtx_assert(&vnode_list_mtx, MA_NOTOWNED); - rnumvnodes = atomic_fetchadd_long(&numvnodes, 1) + 1; - if (vnlru_under(rnumvnodes, vlowat)) - vnlru_kick_cond(); + atomic_add_long(&numvnodes, 1); + vnlru_kick_cond(); return (uma_zalloc_smr(vnode_zone, M_WAITOK)); }