From eugen@grosbein.net Tue May 3 15:13:26 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 682381ACC7D7; Tue, 3 May 2022 15:13:45 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kt3Q02qffz4TMh; Tue, 3 May 2022 15:13:44 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.16.1/8.16.1) with ESMTPS id 243FDXFj054249 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 May 2022 15:13:34 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: jhs@berklix.com Received: from [10.58.0.11] (dadvw [10.58.0.11] (may be forged)) by eg.sd.rdtc.ru (8.16.1/8.16.1) with ESMTPS id 243FDV2E051341 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 3 May 2022 22:13:31 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: breaking modules To: "Julian H. Stacey" , freebsd-stable@FreeBSD.org References: <202205031447.243EkmY5077471@fire.js.berklix.net> Cc: freebsd-current@FreeBSD.org, Ed Maste From: Eugene Grosbein Message-ID: <1143af76-e4fe-6169-0cc8-9397b54c2afd@grosbein.net> Date: Tue, 3 May 2022 22:13:26 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 In-Reply-To: <202205031447.243EkmY5077471@fire.js.berklix.net> Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT autolearn=disabled version=3.4.2 X-Spam-Report: * -0.0 SHORTCIRCUIT No description available. * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 4Kt3Q02qffz4TMh X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=fail (mx1.freebsd.org: domain of eugen@grosbein.net does not designate 2a01:4f8:c2c:26d8::2 as permitted sender) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [-2.10 / 15.00]; ARC_NA(0.00)[]; R_SPF_FAIL(1.00)[-all]; FREEFALL_USER(0.00)[eugen]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[freebsd-current,freebsd-stable]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N 03.05.2022 21:46, Julian H. Stacey wrote: > Hi, Reference: >> From: "Julian H. Stacey" >> Date: Fri, 29 Apr 2022 23:57:02 +0200 > > "Julian H. Stacey" wrote: >> Ed Maste wrote: >>> On Thu, 28 Apr 2022 at 11:28, Julian H. Stacey wrote: >>>> >>>> but that's crude. It's nice to be able to build most modules ready >>>> in case wanted later, so how about a DUDS env. mechanism like ports/ ? >>> >>> I'd rather not add additional complexity to our build infrastructure >>> to address a situation that shouldn't exist. Modules should build & >>> function on an ongoing basis (and, I believe they generally do). CI >>> doesn't report any issues on either stable branch or main at present. >> >> I'm building stable-12 not stable-13. It's broken here. I've seen modules break >> for years, I used to suspect modules werent built by default by >> build engines as often as main src/, so modules had more time to rot against >> changing includes & libs, maybe now build engines might compile >> them as often as eg bin/ls/ ? I don't know; But I'm seeing modules breaks. >> >> I just refetched with git this mid Friday afternoon (TZ=+02:00) 12.3-STABLE >> & the 2 breaks are still present. See below. >> >> Setting a MODULE_DUDS would save work rather than repetitively retro >> patching out the same modules in Makefile after each git pull --ff-only. >> >> I'd happily develop a patch for sys/modules/, but if someone >> else prefers to, that might increase the chance of it being commited. >> I'd be happy to test or develop a fix for sys/modules/Makefile. > > Eugene Grosbein wrote: >> Unfortunately, CI does not catch stand-alone module build failures, >> out of kernel build directory. >> >> For example: >> >> if_em https://cgit.freebsd.org/src/commit/?id=c0460cf2e42d2819c1f191a1d6e1b3dc0c7ea010 >> if_epair https://cgit.freebsd.org/src/commit/?id=7a382e744b0b0ba9b51dc34bfa0cd1515f744f25 >> linuxkpi https://cgit.freebsd.org/src/commit/?id=f5a2e7b0e8483bf51519046fd149a6a31acef6b1 > > > I developed a fix, patch appended, mastered inc. a mini test Makefile at > http://berklix.com/~jhs/src/bsd/fixes/freebsd/src/gen/sys/modules/ > > Filed with https://bugs.freebsd.org/bugzilla/enter_bug.cgi as > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263758 > > I added cc: current@, Would someone like to try it please ? > > BTW I've not yet but will later read how DUDS is implemented in > /usr/ports/Mk/bsd.port.subdir.mk I filled https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263750 with a patch fixing standalone build of random_fortuna and random_other. Please test the patch in the PR 263750 and report back if it fixes the problem for you, too.