From owner-svn-src-head@FreeBSD.ORG  Mon Jan  5 20:43:57 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B4E60106566B;
	Mon,  5 Jan 2009 20:43:57 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
	[128.208.78.105])
	by mx1.freebsd.org (Postfix) with ESMTP id 777A68FC20;
	Mon,  5 Jan 2009 20:43:57 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
	[127.0.0.1])
	by troutmask.apl.washington.edu (8.14.3/8.14.3) with ESMTP id
	n05Khv5o084924; Mon, 5 Jan 2009 12:43:57 -0800 (PST)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
	by troutmask.apl.washington.edu (8.14.3/8.14.3/Submit) id
	n05KhvZe084918; Mon, 5 Jan 2009 12:43:57 -0800 (PST)
	(envelope-from sgk)
Date: Mon, 5 Jan 2009 12:43:56 -0800
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: "Bjoern A. Zeeb" <bz@freebsd.org>
Message-ID: <20090105204356.GA52934@troutmask.apl.washington.edu>
References: <200901042153.n04LrgkD075147@svn.freebsd.org>
	<20090104220716.GL14235@hoeg.nl>
	<alpine.BSF.2.00.0901042213530.67103@fledge.watson.org>
	<20090105172400.T45399@maildrop.int.zabbadoz.net>
	<49624DB9.8080900@gmx.de>
	<20090105194210.P45399@maildrop.int.zabbadoz.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090105194210.P45399@maildrop.int.zabbadoz.net>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	Christoph Mallon <christoph.mallon@gmx.de>, src-committers@freebsd.org
Subject: Re: svn commit: r186751 - in head/sys: netinet6 netipsec
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jan 2009 20:43:58 -0000

On Mon, Jan 05, 2009 at 07:45:47PM +0000, Bjoern A. Zeeb wrote:
> On Mon, 5 Jan 2009, Christoph Mallon wrote:
> 
> Hi,
> 
> >Bjoern A. Zeeb schrieb:
> >>I have broken it out from a larger patch; the C99 initializer is here:
> >>http://people.freebsd.org/~bz/20090105-02-c99-initializers.diff
> >>
> >>I case someone can give it a quick glance I'll commit them.
> >
> >+	.pr_flags	= PR_ATOMIC|PR_ADDR,
> >
> >style(9) wants spaces around binary operators.
> 
> I am not sure it does. In case it does I am not going to break
> consistency with all other 65 places that don't do for pr_flags;
> but it seems I should change the <tab>=<space> to <space>=<tab>.
> Thanks for making me look, and thanks for review!
> 

>From style(9):

    Unary operators do not require spaces, binary operators do.

and

    Stylistic changes (including whitespace changes) are hard on
	the source repository and are to be avoided without good reason. 

So, it appears your change conforms to the prevailing style of the
file, and is acceptable.

-- 
Steve