From owner-freebsd-current@FreeBSD.ORG  Fri Jul 18 00:13:35 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 744B4106566C
	for <current@freebsd.org>; Fri, 18 Jul 2008 00:13:35 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 1FC7C8FC1D
	for <current@freebsd.org>; Fri, 18 Jul 2008 00:13:35 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from localhost (localhost [127.0.0.1])
	by pele.citylink.co.nz (Postfix) with ESMTP id 2C6532BDA5;
	Fri, 18 Jul 2008 11:56:38 +1200 (NZST)
X-Virus-Scanned: Debian amavisd-new at citylink.co.nz
Received: from pele.citylink.co.nz ([127.0.0.1])
	by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id lfZj-itjrHtr; Fri, 18 Jul 2008 11:56:34 +1200 (NZST)
Received: from citylink.fud.org.nz (unknown [202.8.44.45])
	by pele.citylink.co.nz (Postfix) with ESMTP;
	Fri, 18 Jul 2008 11:56:31 +1200 (NZST)
Received: by citylink.fud.org.nz (Postfix, from userid 1001)
	id 9B09911431; Fri, 18 Jul 2008 11:56:30 +1200 (NZST)
Date: Thu, 17 Jul 2008 16:56:30 -0700
From: Andrew Thompson <thompsa@FreeBSD.org>
To: Pyun YongHyeon <yongari@FreeBSD.org>
Message-ID: <20080717235630.GL33414@citylink.fud.org.nz>
References: <200805190140.m4J1e0YW001168@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200805190140.m4J1e0YW001168@repoman.freebsd.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: current@freebsd.org
Subject: Re: cvs commit: src/sys/dev/age if_age.c if_agereg.h if_agevar.h
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jul 2008 00:13:35 -0000

On Mon, May 19, 2008 at 01:39:59AM +0000, Pyun YongHyeon wrote:
> yongari     2008-05-19 01:39:59 UTC
> 
>   FreeBSD src repository
> 
>   Added files:
>     sys/dev/age          if_age.c if_agereg.h if_agevar.h 
>   Log:
>   Add age(4), a driver for Attansic/Atheros L1 gigabit ethernet
>   controller.

+static void
+age_phy_reset(struct age_softc *sc)
+{
+
+        /* Reset PHY. */
+        CSR_WRITE_4(sc, AGE_GPHY_CTRL, GPHY_CTRL_RST);
+        pause("agephy", hz / 1000);
+        CSR_WRITE_4(sc, AGE_GPHY_CTRL, GPHY_CTRL_CLR);
+        pause("agephy", hz / 1000);
+}

This will panic if hz < 1000, perhaps a DELAY(1) is better?


Andrew