Date: Mon, 24 Aug 2015 04:12:19 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 202404] [MAINTAINER] multimedia/mplayer2: updates to Makefile Message-ID: <bug-202404-13-05E8MzlnwL@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-202404-13@https.bugs.freebsd.org/bugzilla/> References: <bug-202404-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202404 --- Comment #9 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 160285 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D160285 v4 > @@ -25,7 +25,6 @@ > CONFIGURE_ARGS=3D --cc=3D${CC} \ > --extra-libs=3D'-lavresample ${PORTAUDIOLIB}' \ > --mandir=3D${PREFIX}/man \ > - --enable-libavresample \ What's the rationale? > +OPTIONS_DEFINE=3D ... V4L ... If it was previously commented out and didn't work then don't advertise it. Option helpers can be left uncommented as they wouldn't be used. > -.if ${PORT_OPTIONS:MIPV6} > -CATEGORIES+=3D ipv6 > -.else > -CONFIGURE_ARGS+=3D --disable-inet6 > -.endif [...] > +IPV6_CONFIGURE_ON=3D --enable-inet6 > +IPV6_CONFIGURE_OFF=3D --disable-inet6 CATEGORIES is lost? > +ASS_CONFIGURE_OFF=3D --disable-libass --disable-enca Make it ASS_IMPLIES=3DENCA instead. > +CACA_CONFIGURE_ON=3D --enable-caca > +CACA_CONFIGURE_OFF=3D --disable-caca Better replace such instances with the likes of CACA_CONFIGURE_ENABLE=3D caca > +THEORA_EXTRA_LIBS=3D -ltheoradec > +V4L_EXTRA_LIBS=3D -lv4l2 [...] > +.if defined(THEORA_EXTRA_LIBS) > +CONFIGURE_ARGS+=3D --extra-libs=3D"${THEORA_EXTRA_LIBS}" > +.endif > +.if defined(V4L_EXTRA_LIBS) > +CONFIGURE_ARGS+=3D --extra-libs=3D"${V4L_EXTRA_LIBS}" > +.endif This isn't going to work. Each instance of --extra-libs overrides the previ= ous one. Try using standard variable. CONFIGURE_ARGS+=3D --extra-libs=3D"${LIBS}" [...] THEORA_LIBS=3D -ltheoradec V4L_LIBS=3D -lv4l2 > -.if ${PORT_OPTIONS:MX11} > -USE_XORG=3D x11 xv xxf86vm > -.if ${PORT_OPTIONS:MOPENGL} > -USE_XORG+=3D glproto > -.if ${PORT_OPTIONS:MXINERAMA} > -USE_XORG+=3D xinerama xineramaproto > +OPENGL_USE=3D GL=3Dgl XORG=3Dglproto > +XINERAMA_USE=3D XORG=3Dxinerama,xineramaproto Lossy conversion. Where are _IMPLIES=3D X11 ? > .include <bsd.port.options.mk> This line should disappear. >=20 > .if ${ARCH} =3D=3D "sparc64" > BROKEN=3D Does not compile on sparc64 > .endif Convert into BROKEN_sparc64. > +--- configure.orig 2013-07-09 16:33:11 UTC > ++++ configure [...] > +- for _cc in "$_cc" gcc cc ; do > ++ for _cc in "$_cc" cc cc ; do Same mistake as v3. You're converting post-patch into files/patch-configure. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-202404-13-05E8MzlnwL>