From owner-freebsd-bugs@FreeBSD.ORG  Sun Jan 15 15:34:56 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F3B29106564A
	for <freebsd-bugs@FreeBSD.org>; Sun, 15 Jan 2012 15:34:55 +0000 (UTC)
	(envelope-from bugReporter@Haakh.de)
Received: from mo-p00-ob6.rzone.de (mo-p00-ob6.rzone.de
	[IPv6:2a01:238:20a:202:53f0::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 2128A8FC14
	for <freebsd-bugs@FreeBSD.org>; Sun, 15 Jan 2012 15:34:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1326641692; l=1041;
	s=domk; d=haakh.de;
	h=Content-Transfer-Encoding:Content-Type:Subject:To:MIME-Version:From:
	Date:X-RZG-CLASS-ID:X-RZG-AUTH;
	bh=nfgKhT4Ig+Z8y6ShuKlrtvPOQcU=;
	b=DHDmjv6hVPakoAk2AzlP6vjv8WXvNPA2WEOSyDX76y7E9ascVQyJT+t37I76Vh91zGu
	UwYCy2Tvmo+LdjPkjpZIopR/rXZYD4Gwqgdw1LF1k/IajOlEMksNVQRevMX0aTBkOEhmH
	vZtkVxHZuY/NhcnjFfX0AcTWNOCcEXLQUzM=
X-RZG-AUTH: :LWQcbViwW/e6OTbW0dHzwKkCepY3+zAQY9KdRPw9VcHc3bN9H/XwW+L38w0=
X-RZG-CLASS-ID: mo00
Received: from abaton.Haakh.de (p57A71367.dip.t-dialin.net [87.167.19.103])
	by smtp.strato.de (cohen mo22) (RZmta 27.4 DYNA|AUTH)
	with ESMTPA id R006c3o0FEZktk for <freebsd-bugs@FreeBSD.org>;
	Sun, 15 Jan 2012 16:34:52 +0100 (MET)
Received: from Crabberio.Haakh.de (crabberio.Haakh.de [192.168.63.16])
	by abaton.Haakh.de (8.14.5/8.14.5) with ESMTP id q0FFYmTM006869
	for <freebsd-bugs@FreeBSD.org>; Sun, 15 Jan 2012 16:34:49 +0100 (CET)
	(envelope-from bugReporter@Haakh.de)
Message-ID: <4F12F218.2070402@Haakh.de>
Date: Sun, 15 Jan 2012 16:34:48 +0100
From: "Dr. A. Haakh" <bugReporter@Haakh.de>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:9.0.1) Gecko/20111225 Firefox/9.0.1 SeaMonkey/2.6.1
MIME-Version: 1.0
To: freebsd-bugs@FreeBSD.org
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: bug in rc-script
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jan 2012 15:34:56 -0000

Recently I found the reason for an old bug, which I could not trace down 
for a long time:
the rc-script for freenet6 caused the trouble. Runnung rcoder (a tool 
which was mentioned on a mailing-list) revealed a lot of 'circular 
dependencies' which messed up the rc-system.
-----<snip>-----
#
# PROVIDE: freenet6
# REQUIRE: NETWORKING netif named
# BEFORE: ip6addrctl
# KEYWORD: shutdown
#
-----<snip>-----
Deactivating 'BEFORE' solved the problem for me but the question arose: 
how could this happen?

Porters Handbook chapter "6.23 Starting and stopping services (rc 
scrips)" references rcoder but in chapter "6.23.2 Pre-Commit-Checklist" 
containing many good proposals an explicit hint to run rcorder on an 
included rc-file is missing.

Tinderbox misses this error as well and probably portlint too.

So here is my proposal:
add an item to the Pre-Commit-Checklist to run rcorder, modify portlint 
and/or tinderbox to check rc-files.

I will file a bugreport for freenet6, what about the rest?

Thanks
Andreas