From owner-freebsd-arch@FreeBSD.ORG Thu Jan 12 21:29:43 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 731F11065670; Thu, 12 Jan 2012 21:29:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id E95EE8FC1B; Thu, 12 Jan 2012 21:29:41 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q0CLTb76062112 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 12 Jan 2012 23:29:37 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q0CLTb0G087012; Thu, 12 Jan 2012 23:29:37 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q0CLTaRV087011; Thu, 12 Jan 2012 23:29:36 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 12 Jan 2012 23:29:36 +0200 From: Kostik Belousov To: Mikolaj Golub Message-ID: <20120112212936.GB31224@deviant.kiev.zoral.com.ua> References: <86sjjobzmn.fsf@kopusha.home.net> <86fwfnti5t.fsf@kopusha.home.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="w0Yn8slUAuN8hGpX" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: "Robert N. M. Watson" , freebsd-arch@freebsd.org Subject: Re: unix domain sockets on nullfs(5) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 21:29:43 -0000 --w0Yn8slUAuN8hGpX Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 12, 2012 at 11:17:26PM +0200, Mikolaj Golub wrote: > On Tue, Jan 10, 2012 at 10:30 PM, Mikolaj Golub wro= te: > > > > On Tue, 10 Jan 2012 14:02:34 +0000 Robert N. M. Watson wrote: > > > > =9ARNMW> (1) I don't think the new behaviour should be optional -- it w= as always > > =9ARNMW> the intent that nullfs pass through all behaviours to the unde= rlying > > =9ARNMW> layer, it's just that certain edge cases didn't appear in the = original > > =9ARNMW> implementation. Memory mapping was fixed a few years ago using= similar > > =9ARNMW> techniques. This will significantly reduce the complexity of y= our > > =9ARNMW> patch, and also avoid user confusion since it will now behave = "as > > =9ARNMW> expected". Certainly, mention in future release notes would be > > =9ARNMW> appropriate, however. > > > > I don't mind having only the new behavior, as I can't imagine where I w= ould > > need a nullfs with nosobypass option mounted and I also like when thing= s are > > simple :-). > > > > On the other hand there might be people who relied on the old behavior = and who > > would be surprised if it had changed. > > > > So, if other people agree I will remove the old behaviour to make the p= atch > > simpler. Another option would be to have sobypass by default with possi= bility > > to (re)mount fs with nosobypass. > > >=20 > If we agree to have only the new behavior then nullfs won't need modifica= tion > at all, it will work as expected automatically. The patch could be (with = updated > locking for the connect case): >=20 > http://people.freebsd.org/~trociny/VOP_UNP.1.patch I suggest to split the exclusive->shared locking change into separate patch, to be committed either before or after the VOP_UNP (better to do it before to not change the interface of VOP). You do not need local variable vp in the default implementations of vops at all, use ap->a_vp directly. --w0Yn8slUAuN8hGpX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk8PUMAACgkQC3+MBN1Mb4jA3wCgwDHY51VQBqrpGtLS27vVgq0i E6QAmwZ73vFa1/UmLcExvGm6Fo5A2TGk =ok8J -----END PGP SIGNATURE----- --w0Yn8slUAuN8hGpX--